Closed Bug 628980 Opened 14 years ago Closed 14 years ago

browserscope richedit tests load http://www.google.com/intl/en_ALL/images/logo.gif over the network

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b11
Tracking Status
status1.9.2 --- .17-fixed
status1.9.1 --- .19-fixed

People

(Reporter: ted, Assigned: ehsan.akhgari)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Running mochitest-3/5 with Wireshark running, I caught this test making an external network request: GET /intl/en_ALL/images/logo.gif HTTP/1.1 Host: www.google.com User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110105 Firefox/4.0b9pre Accept: image/png,image/*;q=0.8,*/*;q=0.5 Accept-Language: en-us,en;q=0.5 Accept-Encoding: gzip, deflate Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive: 115 Connection: keep-alive Referer: http://mochi.test:8888/tests/editor/libeditor/html/tests/browserscope/lib/richtext/richtext/editable.html We need to fix this test to not hit the network.
Attached patch Patch (v1) (obsolete) (deleted) — Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #507332 - Flags: review?(roc)
Comment on attachment 507332 [details] [diff] [review] Patch (v1) This is OK, but would it be slightly better to use an image file loaded through the mochitest http server?
Attachment #507332 - Flags: review?(roc) → review+
(In reply to comment #2) > This is OK, but would it be slightly better to use an image file loaded through > the mochitest http server? Why would that be better?
Attached patch For check-in (deleted) — Splinter Review
Well, I guess I don't care much either way!
Attachment #507332 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
Looks like the test has been around for a while, we'll need it on 1.9.2 and 1.9.1 too.
status1.9.1: --- → ?
status1.9.2: --- → ?
Keywords: checkin-needed
Whiteboard: [c-n on 1.9.1 and 1.9.2]
Version: unspecified → Trunk
Pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d69d7cf95377 Had to fiddle the patch because the tests had been renamed on trunk.
Version: Trunk → unspecified
The "3.6.15" we're releasing today does not fix this bug, the release containing this bug fix has been renamed to "3.6.16" and the bugzilla flags will be updated to reflect that soon. Today's release is a re-release of 3.6.14 plus a fix for a bug that prevented many Java applets from starting up.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: