Closed
Bug 628984
Opened 14 years ago
Closed 14 years ago
test_Microformats_hCalendar.html loads http://conferences.oreillynet.com/images/et2005/logo_sm.gif over the network
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 4.0b11
People
(Reporter: ted, Assigned: philor)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Running Mochitests with Wireshark running showed this test making an external network request:
GET /images/et2005/logo_sm.gif HTTP/1.1
Host: conferences.oreillynet.com
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110105 Firefox/4.0b9pre
Accept: image/png,image/*;q=0.8,*/*;q=0.5
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip, deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 115
Connection: keep-alive
Referer: http://mochi.test:8888/tests/toolkit/components/microformats/tests/test_Microformats_hCalendar.html
Kind of silly, looks like it's just an <img> tag. We should fix this test to use the test server, and load this from http://mochi.test or example.com.
Comment 1•14 years ago
|
||
hCard uses:
http://mochi.test:8888/tests/browser/microformats/test/picture.png
It doesn't actually need to exust.
Assignee | ||
Comment 2•14 years ago
|
||
Indeed, the test doesn't mind at all.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #508081 -
Flags: review?(gavin.sharp)
Comment 3•14 years ago
|
||
Comment on attachment 508081 [details] [diff] [review]
Fix
rs=me
Attachment #508081 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b11
Version: unspecified → Trunk
Assignee | ||
Comment 5•14 years ago
|
||
Need to land it on 1.9.2 and 1.9.1 too, sometime earlier in a day.
status1.9.1:
--- → ?
status1.9.2:
--- → ?
Reporter | ||
Comment 6•14 years ago
|
||
Pushed to 1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/71139309b45d
I had to change the hostname in the image URL from mochi.test to localhost, since the mochi.test changes didn't land on 1.9.2.
Reporter | ||
Comment 7•14 years ago
|
||
Comment 8•14 years ago
|
||
The "3.6.15" we're releasing today does not fix this bug, the release containing this bug fix has been renamed to "3.6.16" and the bugzilla flags will be updated to reflect that soon. Today's release is a re-release of 3.6.14 plus a fix for a bug that prevented many Java applets from starting up.
You need to log in
before you can comment on or make changes to this bug.
Description
•