Closed
Bug 629893
Opened 14 years ago
Closed 13 years ago
Entity "props.policy.label" [ @ cookieAcceptDialog.dtd ] is unused and should be removed
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: hubert+bmo, Assigned: hubert+bmo)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
Entity "props.policy.label" is unused - it should be removed
https://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/cookie/cookieAcceptDialog.dtd#7
Found in cookieAcceptDialog.dtd file only:
https://mxr.mozilla.org/mozilla-central/search?string=props.policy.label&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
There is no mentioned entity in cookieAcceptDialog.xul:
https://mxr.mozilla.org/mozilla-central/source/toolkit/components/cookie/content/cookieAcceptDialog.xul
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → hubert
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #508117 -
Flags: review?
Assignee | ||
Updated•14 years ago
|
Attachment #508117 -
Flags: review? → review?(gavin.sharp)
Updated•14 years ago
|
Attachment #508117 -
Flags: review?(gavin.sharp) → review+
Comment 2•14 years ago
|
||
This seems to be a fall-out from unreviewed parts landing as part of http://hg.mozilla.org/mozilla-central/rev/b19ea8c3d39c from bug 383993.
This is looong gone, doesn't hurt to carry it around for a few more weeks.
Let's land this post-fx4.
Depends on: 383993
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Axel Hecht [:Pike] from comment #2)
> Let's land this post-fx4.
It's time.
Comment 4•13 years ago
|
||
Can you create an updated patch following the guidelines on http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed and set the checkin-needed flag here?
Assignee | ||
Comment 5•13 years ago
|
||
Attachment #508117 -
Attachment is obsolete: true
Assignee | ||
Comment 6•13 years ago
|
||
I forgot about the comment in patch.
Attachment #588181 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 7•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla12
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•