Closed
Bug 630288
Opened 14 years ago
Closed 14 years ago
MiniDumpCallback in nsExceptionHandler.cpp uses too much stack
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: billm, Assigned: billm)
References
Details
(Whiteboard: [softblocker][fixed-in-tracemonkey])
Attachments
(1 file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Breakpad allocates 8K of stack, and given the two paths it allocates, it uses more than 8K.
|
Assignee | |
Comment 1•14 years ago
|
||
This moves these buffers out of the stack.
Attachment #508480 -
Flags: review?(ted.mielczarek)
|
||
Updated•14 years ago
|
Assignee: nobody → wmccloskey
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 508480 [details] [diff] [review]
fix
You'll need approval here, but if this is blocking a blocker, then that should be fairly easy. Thanks for finding this!
Attachment #508480 -
Flags: review?(ted.mielczarek)
Attachment #508480 -
Flags: review+
Attachment #508480 -
Flags: approval2.0?
|
|
Assignee | |
Comment 3•14 years ago
|
||
This is important because the patch in bug 609104 is orange without this fix.
|
||
Comment 4•14 years ago
|
||
We're sure/pretty sure that if two plugins simultaneously crash, we won't be overwriting these buffers? (Are all crashes processed on the same thread?)
|
|
||
Comment 5•14 years ago
|
||
That code path isn't used for plugin crashes, only main process crashes. Breakpad has locking around the exception handling that we use for the main process:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/linux/handler/exception_handler.cc#258
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/windows/handler/exception_handler.cc#433
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/mac/handler/exception_handler.cc#280
|
||
Comment 6•14 years ago
|
||
Blocks a blocker, so its a blocker.
|
|
||
Updated•14 years ago
|
blocking2.0: --- → final+
Whiteboard: [softblocker]
|
|
||
Updated•14 years ago
|
Attachment #508480 -
Flags: approval2.0?
|
|
Assignee | |
Comment 7•14 years ago
|
||
Whiteboard: [softblocker] → [softblocker][fixed-in-tracemonkey]
|
||
Comment 8•14 years ago
|
||
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/6a5665476ee4
|
|
||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•