Open Bug 630460 Opened 14 years ago Updated 2 years ago

Command-w doesn't close the web inspector window and instead is passed through to the open tab

Categories

(Core :: Widget, defect)

defect

Tracking

()

People

(Reporter: christian, Unassigned)

References

Details

(Keywords: polish)

1. Open web console 2. Open the web inspector to inspect a request 3. Make sure the web inspector is active by clicking on the window 4. Press command-w 5. Observe the web inspector is still open and the Firefox tab closes instead This is on beta 10, I'll check the latest nightly in a bit.
still a bug. We should probably wire ESC up to close the inspector panels too, though I'm not sure if adding keyboard shortcuts violates string freeze or not? I'm guessing they do, so this might have to wait until 4+whatever.
Keywords: polish
ps, thanks for filing!
OS: Mac OS X → All
This is really a widget bug, no? Do we have the ability to focus the panel like a window?
panels and their contents can be focused like other widgets. Especially if they have titlebars. Not sure how a cmd-w would work in one though since they inherit keycommands from the main window's document. Panels with noautohide=true can be dismissed with an ESC key, iirc. Maybe we need a separate closekey attribute or something. I guess we could work-around by adding a key-listener to our panels. Moving to Widgets for an Enn consult.
Component: Developer Tools → Widget
Product: Firefox → Core
QA Contact: developer.tools → general
It seems like cmd-w should close those panels when they're focused given that they *look* like windows.
Pinging this bug to see if enn has any input here. This is still annoying behavior.
We don't actually maintain any state relating to which panel is active, this is only done by the OS. We could add the ability to have <keyset>s that are defined for panels, but that would need the ability to have keys that could be redirected through a panel first. Is there a case where the panel looks active but something on the main page is focused? Is this kind of support needed? Note that on Mac at least, native panels don't close with Cmd+W. (the Font dialog for example)
This is more than a polish issue for any Linux users that use window managers that don't have window decorations (such as a "close" button) -- it's impossible for us to close these inspectors without closing the web console as a whole.
(In reply to Ben Hearsum [:bhearsum] from comment #9) > This is more than a polish issue for any Linux users that use window > managers that don't have window decorations (such as a "close" button) -- > it's impossible for us to close these inspectors without closing the web > console as a whole. +1 here. I also can't close any of those windows unless I restart firefox (or, as I just learned from ben's comment - closing the web console works too :S duh!) Is there a bug for the linux problem of no close buttons?
(In reply to Pedro Alves from comment #10) > (In reply to Ben Hearsum [:bhearsum] from comment #9) > > This is more than a polish issue for any Linux users that use window > > managers that don't have window decorations (such as a "close" button) -- > > it's impossible for us to close these inspectors without closing the web > > console as a whole. > > +1 here. I also can't close any of those windows unless I restart firefox > (or, as I just learned from ben's comment - closing the web console works > too :S duh!) > > Is there a bug for the linux problem of no close buttons? that's bug 590558.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.