Closed
Bug 631269
Opened 14 years ago
Closed 13 years ago
Reduce duplicate code in CloneAndReplaceChild
Categories
(Core :: DOM: Navigation, defect, P2)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: mossop, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Bug 602256 made both paths there do the same thing in some cases so it is probably possible to reduce the duplicate code there, or just replace the whole function with a simpler function.
|
||
Comment 1•14 years ago
|
||
Dave, you want to take this, or should I?
|
Reporter | |
Comment 2•14 years ago
|
||
I probably wouldn't get around to it for a while
|
|
||
Updated•14 years ago
|
Assignee: nobody → bzbarsky
Priority: -- → P2
|
Assignee | |
Comment 3•13 years ago
|
||
Something like this, perhaps?
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 535599 [details] [diff] [review]
Patch v1
Yep, like that.
Attachment #535599 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•