Closed
Bug 631448
Opened 14 years ago
Closed 14 years ago
Try TBPL should link to build directory
Categories
(Tree Management Graveyard :: TBPL, enhancement)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: mounir)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
Swatinem
:
review+
|
Details | Diff | Splinter Review |
It would be nice if I get from TBPL to downloadable builds easily.
For Try, the URLs can be constructed from the pusher and rev:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/jdaggett@mozilla.com-920fe6f57d17/
For non-Try, it might be harder, because the URLs are like:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx-debug/1296793077/
|
Assignee | |
Comment 1•14 years ago
|
||
This is adding a link to the build directory just before short/long log links.
The build is only shown if you click on a build. Not that we can't show it every time but I assume you might not be interested by it if you click on a test job.
This patch handles thunderbird try server too ;)
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #512158 -
Flags: review?(arpad.borsos)
|
|
Assignee | |
Updated•14 years ago
|
Summary: Try TBPL should link to downloadable builds → Try TBPL should link to build directory
|
|
Assignee | |
Updated•14 years ago
|
Attachment #512158 -
Flags: review?(mstange)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 512158 [details] [diff] [review]
Patch v1
I hope you have checked if there is enough space for the link? (I didn’t)
>+ var dir = "firefox";
>+ if (repo == 'try-comm-central') {
>+ dir = "thunderbird";
>+ }
I like the ? : syntax more, but its fine either way.
>+ return '<a href="https://ftp.mozilla.org/pub/mozilla.org/' +
>+ dir + '/tryserver-builds/' + result.push.pusher + '-' +
>+ result.revs[repo] + '/">go to build directory</a>';
Never knew this was available using https, guess I learn new things all the time :-)
Attachment #512158 -
Flags: review?(mstange)
Attachment #512158 -
Flags: review?(arpad.borsos)
Attachment #512158 -
Flags: review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•