Closed
Bug 631491
Opened 14 years ago
Closed 14 years ago
toolbar's iconsize attribute is not updated correctly after switching themes
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 4.0
Tracking | Status | |
---|---|---|
blocking2.0 | --- | .x+ |
People
(Reporter: mstange, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
Dolske
:
review+
Dolske
:
approval2.0+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110203 Firefox/4.0b12pre
Built from http://hg.mozilla.org/mozilla-central/rev/f2a6a78478dc
Steps to reproduce:
1. Use the default theme on Mac with large icons mode.
Now iconsize="large" is set on the toolbox and iconsize="small" on the toolbar.
2. Install and enable this theme: https://addons.mozilla.org/en-US/firefox/addon/walnut2-for-firefox/
3. Restart Firefox.
Expected results:
After the restart, iconsize="large" should be set on both the toolbox and the toolbar since this theme doesn't use counter-reset: smallicons.
Actual results:
The toolbars still have iconsize="small" set on them. Restarting another time doesn't change this, only double-flipping the checkbox in the customization panel does.
Assignee | ||
Updated•14 years ago
|
Component: Theme → General
QA Contact: theme → general
Assignee | ||
Comment 1•14 years ago
|
||
simple solution: don't persist the adjusted iconsize
Assignee | ||
Updated•14 years ago
|
OS: Mac OS X → All
Assignee | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Keywords: regression
blocking2.0: ? → .x
Assignee | ||
Updated•14 years ago
|
Attachment #509732 -
Flags: review?(dolske)
Comment 3•14 years ago
|
||
Any chance this patch to be landed before 4.0? This bug will for sure annoy users from third-party themes and it seems this is a no-risk patch at all.
Updated•14 years ago
|
Attachment #509732 -
Flags: review?(mano)
Attachment #509732 -
Flags: review?(dolske)
Attachment #509732 -
Flags: review+
Attachment #509732 -
Flags: approval2.0+
Assignee | ||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0
Comment 6•14 years ago
|
||
Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0
Verified issue and it's no longer present.
Status: RESOLVED → VERIFIED
Comment 7•14 years ago
|
||
WFM on:
Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0
Comment 8•14 years ago
|
||
Sadly, this "no risk" patch caused a regression.
You need to log in
before you can comment on or make changes to this bug.
Description
•