Closed Bug 632271 Opened 14 years ago Closed 3 years ago

Entirely remove support for quit dialog

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: zpao, Unassigned)

References

Details

We've now made the quit dialog not show by default. Eventually we'd like to remove support for showing it entirely, so this is that bug.
I still get that dialog and I would not like it to be removed. How is Mozilla ever going to come out with Firefox 4,5,6 & 7 if you still go on making stupid changes that do not need to be made. This roadmap for 2011 has now turned into the Net's largest joke. https://wiki.mozilla.org/Firefox/Roadmap
It is time to start some productive work if Firefox 4 is to be out this year let alone 7!
Why remove that dialog while people are complaining because there isn't that dialog on firefox 4 beta beta 10?
It is very easy to not have that dialog shown ever again. Why do you want to remove a preference for people who want it shown? We don't want to accidentally close the entire Firefox with a stray misclick. Some of us have a setting to erase all private data on quit, so this becomes an even worse problem.
(In reply to comment #3)
> It is very easy to not have that dialog shown ever again. Why do you want to
> remove a preference for people who want it shown? We don't want to accidentally
> close the entire Firefox with a stray misclick.

+1
(In reply to comment #4)
> (In reply to comment #3)
> > It is very easy to not have that dialog shown ever again. Why do you want to
> > remove a preference for people who want it shown? We don't want to accidentally
> > close the entire Firefox with a stray misclick.
> 
> +1
+1(,e+∞)
This was a nonsense decision.

I usually start firefox with the home page set to SpeedDial.
But, sometimes I need my tabs back on restart: on addons updates, Firefox updates, privacy concerns or just closing the browser, grabbing a coffee and returning to work.
The old way, all I needed to do was choose to save my session on quit.

Now, please, explain to me, how can I do that, after this devs decision?
And removing from configs too, ow man, bad bad decision. 

It seems to me that the rush or need to do something new is hindering development. Please, development team, take a step back and breathe. Try to better evaluate your decisions.
Drifus: It can be done through Firefox button > History > Restore previous session. Although I don't like that it's automatically saved - for instance when surfing on a friend's pc.

Personally, I don't mind it being non-default, as long as I can change it through some settings (even if these are in about:config). But I know a lot of people that *do* mind. If you dislike it, it's not hard to tick "Don't ask next time", is it?

Anyway, *please* don't remove the dialog entirely. I really depend on it.
I don't see the point in removing the dialog either?If you don't want it - check "Don't ask next time".Some of us want to sometimes(unlike the option to show tabs from last time in General settings) save our tabs on exit.
"browser.showQuitWarning; true" is working again in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110209 Firefox/4.0b12pre build. Please check.
Thank you very much, devs team.
"browser.showQuitWarning; true" is definitely *not* working in Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0 (the final 4.0 n Windows XP).
You need to make sure that in preferences, general tab, "When Firefox starts" is not set to "Show my windows and tabs from last time", too.
This is insane. The box should always show, and furthermore, the Ctrl-Q shortcut should be disabled entirely.

At the moment, I'm not a great fan of the "I wanted to close a single tab, my finger slipped a few mm left, and my entire session got destroyed". This one bug makes me say more bad words to my computer than anything else!
(In reply to Paul O'Shannessy [:zpao] from comment #0)
> We've now made the quit dialog not show by default. Eventually we'd like to
> remove support for showing it entirely, so this is that bug.

There is a lot of discussion about the warning message of CTRL-Q being disabled if Restore Previous Session is enabled.

There were so bug reports that make references to it that it was hard to find the correct bug report to write this.

It has been mentioned many times that because CTRL-W and CTRL-Q are so close together, and that since the CTRL-W shortcut is used very often, quite often CTRL-Q is pressed by mistake during an ongoing session. This causes the browser closes down completely without warning, even though this was not the intended action.

The argument here is that since Restore Session is enabled, there should be no Quit Warning, as it is simple to restore the session.

The problem with this is when there are many browser windows and tabs opened, and often many things are actively being done. More often than not, this is the case for most people who use CTRL-W often. When there is a sudden shut down in the middle of work, and then a session restore, the following takes place:

- Large Downloads in progress (LOST)
- Forms being filled in (LOST)
- Form replies received, awaiting printing or saving (LOST)
- Dynamic Pages opened a while ago are not the same again.
- Subscription news site with download limits per day (All START DOWNLODING AGAIN) taking one over the limit
- Already downloaded files (All START DOWNLODING AGAIN)
- Videos that were already watched (All START DOWNLODING AGAIN and start playing at the same time AUTO)
- Radio stations were played at one time but stopped (All START DOWNLODING AGAIN and start playing AUTO)
- Cookies are set to "Always Ask" and multiple cookie confirmation dialogues open up
- I am sure there are others I am forgetting now.

On top of all this, reloading 5 to 15 windows each with multiple tabs takes a lot of time and bandwidth, specially so on slower connections, as well as adding substantially to a quota limit if there is one.

Pressing CTRL-Q by mistake happens to me about once a day. This is because I use CTRL-W many dozens of times a day. It is highly frustrating when the wrong shortcut is pressed. I have to restart the browser, scramble to press ALT-F W ( in Seamonkey ALT-F K) to go off line, wait a few moments, then go back on-line. Then one-by-one go through each browser and each Tab and reload them (letting everything load at once leads to chaos).

One does not close down the browser often at all. Neither is closing down the browser done in a rush. In fact the browser is rarely ever closed down "quickly" using CTRL-Q. Why then is it so important to speed up closing down the browser by just one extra warning? If one was closing and reopening their browser every few minutes, this could be understood, but this is rarely, if ever the case.

The browser is not only a "Browser" any more. It is an integral work space where many things are done, more so now with the Cloud concept increasing.

It is not a good idea to have a commonly mis-pressed shortcut closing down the browser unexpectedly, even if the session can be mostly restored (remember unsent forms, form replies, and dynamic pages will not restore to their previous state). One does not want to see this in any well designed software.

Imagine if Windows Hibernated without warning each time you pressed F1 (instead of the commonly used F2), or if you pressed CTRL-B by mistake instead of CTRL-V, and there was no way we could disable it. We would all throw a fit at MS.

It would be really really REALLY be so very very VERY MUCH appreciated if the developers would seriously consider all the feedback being received, and the logic being presented, so that this was made an option that can be disabled. Please.
I understand the logic here of wanting to remove a dialog box. At the same time, the evil of Ctrl-Q cannot be overstated. Why not do the following:

1. Keep the File -> Quit   menu.
2. Unbind Ctr-Q from doing anything.
3. Allow Ctrl-Q to be re-activated from about:config, if really wanted.

That should keep everyone happy: no accidental dataloss, no loss of functionality, no unnecessary-dialog-bloat.


Please fix this: this is such a simple bug [the minimum fix would be a single line to undefine the Ctrl-Q keybinding], and yet it is the number one source of pain for many Firefox users.
"The browser is not only a "Browser" any more. It is an integral work space where many things are done..." - Free, Comment #13

Very true.  And for a whole variety of (blindingly obvious) reasons, there should always be an option to be warned you're about to quit a multi-tab session - and WITHOUT having to go into about:config, which most users have never heard of.

Both Tab Groups and the new feature below are encouraging large sessions, so it's more important than ever to safeguard them from unintended termination.

The closing multiple tabs warning is used if closing via the button in the top-right corner, so the obvious solution is to extend this to ⌘Q, Firefox button > Exit and File > Exit.

The option says "Warn me when closing multiple tabs".  It does not append "except when I use a shortcut key or menu command"!  And just when is someone going to have that option checked and NOT want a warning on exit?!

The fact that Mozilla communicates changes to Firefox so poorly makes having an intuitive - and thus consistent - interface even more important.  The quit dialog wasn't just phased out, it was suddenly removed leaving millions of users unable to locate their sessions before they were automatically overwritten, because they didn't know the sessions had been saved or where to find them.

Now, a potentially useful feature has been added - a checkbox called 'Don't load tabs until selected'.  But it's greyed out unless you have 'Show my windows and tabs from last time' selected and so VERY easy to miss.  And, of course, having 'Show my windows and tabs from last time' selected stops the quit dialog from working, so the power users with big sessions who've managed to get the quit dialog back - those most likely to benefit from the new feature - are particularly likely to miss it.

Have an intuitive product and be poor communicators, or be good communicators and poor interface designers, but please don't suck at both.
Agree! Options should be simplified with no hidden meaning (except something etc...)
Depends on: 565567
(In reply to Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) from comment #0)
> We've now made the quit dialog not show by default. Eventually we'd like to
> remove support for showing it entirely, so this is that bug.

Why? I think the quit dialog should appear by default at least when quitting by a keyboard shortcut (which may be 	accidentally given).
Flags: needinfo?(paul)
Flags: needinfo?(paul)

We unified this with the close multiple tab dialogs.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.