Linux, which was not affected (as far as the log goes): http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1297155052.1297158726.13175.gz Linux comm-central-trunk debug test mochitest-other on 2011/02/08 00:50:52 { 8200 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/modules/plugin/test/test_crash_submit.xul | Test timed out. 8847 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/modules/plugin/test/test_npruntime.xul | Test timed out. 9500 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/modules/plugin/test/test_privatemode.xul | Test timed out. 10297 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/modules/plugin/test/test_wmode.xul | Test timed out. 10298 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | 4 test timeouts, giving up. 10299 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | Skipping 172 remaining tests. } OSX 10.5 and 10.6 and Windows, which used to have +/- the same failures as Linux, now report: { 12603 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/suite/common/tests/chrome/test_idcheck.xul | Test timed out. 12678 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - autocomplete.controller is undefined at chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete.xul:50 12692 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete2.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - autocomplete.controller is undefined at chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete2.xul:171 12709 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete3.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - autocomplete.controller is undefined at chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete3.xul:171 12736 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete4.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - $("autocomplete").controller is undefined at chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete4.xul:152 } I can't say whether this is an improvement or a regression :-|

NB: *I think test_idcheck.xul was already there: it should probably be ignored here. *I can reproduce with test_autocomplete2.xul alone (for example) on my local Windows 2000 with an opt build.

Ah, bug 631942 revealed these failures, [I don't know about Linux SeaMonkey...] which are caused by bug 611652. [I don't know what Firefox has different.]

FF bug 631918 has not landed yet, it doesn't even have a review as of now. I ported it nevertheless. That's the difference.

(In reply to comment #1) > *I think test_idcheck.xul was already there: it should probably be ignored > here. I would guess this could just need bug 631286. *** (In reply to comment #3) > FF bug 631918 has not landed yet, it doesn't even have a review as of now. (Not landed, but has r+, afaics.) > I ported it nevertheless. That's the difference. So Firefox possibly doesn't fail yet? We'll see when that lands...

(In reply to comment #3) > FF bug 631918 has not landed yet, it doesn't even have a review as of now. I > ported it nevertheless. That's the difference. Bug 631918 has now landed: Firefox passes, SeaMonkey still fails :-| Would this bug depend on some other port(s) not-yet-done?

(In reply to comment #2) > bug 631942 revealed these failures, [I don't know about Linux SeaMonkey...] > which are caused by bug 611652. [I don't know what Firefox has different.] So, too bad I didn't ask this in the first place: Why do you actually think that either of these two is relevant here? * I can reproduce the problem (test_autocomplete2.xul) with or without the changes from bug 631942 * bug 631942 just changed something related to doSync (in addition to removing two unused methods), a method which should never be called in a fresh profile (like used for tests) since no Sync account has been set up there yet * bug 611652 seems to be about something completely different * the issue at hand is that autocomplete.controller is undefined, so wouldn't it rather make sense that some change related to autocompletion would be the cause? And AFAIK we have different autocomplete implementations (XPFE vs. Toolkit), no? * unfortunately I don't understand the test details, but to me the key question is where autocomplete.controller is supposed to be set or removed, and whether it's ever set in cases where the test fails. Without knowing what I'm actually talking about I'd guess it would be added through registerFactory, correct? * the line reported in the error message seems to be off by one * not sure why FF would behave differently than SM there if it's not different autocomplete implementations. Do we have a different test setup, maybe concerning JS (engine) defaults or something?

This bug got worse (though probably more explicit): http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1297731728.1297735269.11901.gz WINNT 5.2 comm-central-trunk debug test mochitest-other on 2011/02/14 17:02:08 { 7749 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/suite/common/places/tests/test_bug549192.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1371 7750 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/suite/common/places/tests/test_bug549192.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1380 7751 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/suite/common/places/tests/test_bug549192.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1371 7752 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/suite/common/places/tests/test_bug549192.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1380 7753 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/suite/common/places/tests/test_bug549192.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1371 7754 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/suite/common/places/tests/test_bug549192.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1380 7755 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/suite/common/places/tests/test_bug549192.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1371 7756 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/suite/common/places/tests/test_bug549192.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1380 7825 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete2.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - autocomplete.controller is undefined at chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete2.xul:171 7833 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete3.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1371 7834 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete3.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1380 7835 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete3.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1371 7836 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_autocomplete3.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1380 7848 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug263683.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1371 7849 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug263683.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1380 7850 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug263683.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1371 7851 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug263683.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run compile-and-go script on a cleared scope at chrome://global/content/autocomplete.xml:1380 } "Change" timeframe: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c46f36d6b1fe&tochange=4c2962ad0a9d Bug 630072!

(In reply to comment #7) > This bug got worse (though probably more explicit): > > http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1297731728.1297735269.11901.gz > WINNT 5.2 comm-central-trunk debug test mochitest-other on 2011/02/14 17:02:08 > { > 7749 ERROR TEST-UNEXPECTED-FAIL | > chrome://mochitests/content/chrome/suite/common/places/tests/test_bug549192.xul > | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - attempt to run > compile-and-go script on a cleared scope at > chrome://global/content/autocomplete.xml:1371 I fixed some errors like this the first time around by canceling the autocomplete request before finishing the test. See https://bugzilla.mozilla.org/attachment.cgi?id=508580&action=diff

(In reply to comment #2) > caused by bug 611652. Bug 611652 comment 15: { Johnny Stenback (:jst, jst@mozilla.com) 2011-02-12 22:09:37 PST (A fix for bug 611653 was landed as http://hg.mozilla.org/tracemonkey/rev/6882211c4a80, mistakenly referring to this bug) } (In reply to comment #8) > I fixed some errors like this the first time around by canceling the > autocomplete request before finishing the test. Yeah, that very fix is what is causing comment 0 errors ;-< This bug is to investigate and fix the current situation...

(In reply to comment #6) > So, too bad I didn't ask this in the first place: Why do you actually think > that either of these two is relevant here? > > * I can reproduce the problem (test_autocomplete2.xul) with or without the > changes from bug 631942 > * bug 631942 just changed something related to doSync (in addition to removing > two unused methods), a method which should never be called in a fresh profile > (like used for tests) since no Sync account has been set up there yet Iirc, I was assuming fixing bug 631942 let more tests run on tinderboxes, so I filed this bug about the newly reported errors. > * bug 611652 seems to be about something completely different > * the issue at hand is that autocomplete.controller is undefined, so wouldn't > it rather make sense that some change related to autocompletion would be the > cause? And AFAIK we have different autocomplete implementations (XPFE vs. > Toolkit), no? xactly, see (comment 8 and) comment 9. > * unfortunately I don't understand the test details, but to me the key question > is where autocomplete.controller is supposed to be set or removed, and whether > it's ever set in cases where the test fails. Without knowing what I'm actually > talking about I'd guess it would be added through registerFactory, correct? > * the line reported in the error message seems to be off by one > * not sure why FF would behave differently than SM there if it's not different > autocomplete implementations. Do we have a different test setup, maybe > concerning JS (engine) defaults or something? Firefox uses http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/autocomplete.xml { 129 <property name="controller" onget="return this.mController;" readonly="true"/> ... 889 controller.stopSearch(); } Ftr, "controller" was added in http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/toolkit/content/widgets/autocomplete.xml&rev=HEAD&mark=1.10#1.11 But SeaMonkey (still) uses http://mxr.mozilla.org/mozilla-central/source/xpfe/components/autocomplete/resources/content/autocomplete.xml { 640 <method name="stopLookup"> } Per http://mxr.mozilla.org/mozilla-central/source/toolkit/content/xul.css#743 { 748 %ifdef MOZ_THUNDERBIRD 749 %define AUTOCOMPLETE_OLD_STYLE 750 %elifdef MOZ_STANDALONE_COMPOSER 751 %define AUTOCOMPLETE_OLD_STYLE 752 %elifdef MOZ_SUITE 753 %define AUTOCOMPLETE_OLD_STYLE 754 %endif ... } So these Toolkit tests were fixed with Firefox specific code :-/

(In reply to comment #10) > Iirc, I was assuming fixing bug 631942 let more tests run on tinderboxes, so I > filed this bug about the newly reported errors. OK, since they are not related I'll remove the dependency. > Firefox uses > http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/autocomplete.xml > { > 129 <property name="controller" onget="return this.mController;" > readonly="true"/> > (...) Ah, that explains it. I have to admit I was too lazy to dig deeper. That said, it should be easy to check for the availability of controller but I'm not so sure about the new alternative code path (haven't checked). Maybe ask Neil? > So these Toolkit tests were fixed with Firefox specific code :-/ To be fair, the "Firefox specific code" is actually Toolkit code, which just happens to not be used by SM and TB right now.

If I then comment out the calls to stopSearch, the tests pass!

(In reply to comment #12) > If I then comment out the calls to stopSearch, the tests pass! (We don't need to call stopSearch because we use setTimeout which gets automatically cancelled when the test is unloaded.)

Comment on attachment 514162 [details] [diff] [review] (Av1) Fix for "An error occurred - attempt to run compile-and-go script on a cleared scope" [Checked in: Comment 16] Lives in m-c but not even part of the Firefox build system.

Comment on attachment 514162 [details] [diff] [review] (Av1) Fix for "An error occurred - attempt to run compile-and-go script on a cleared scope" [Checked in: Comment 16] a=beltzner, NPTOB

Comment on attachment 514162 [details] [diff] [review] (Av1) Fix for "An error occurred - attempt to run compile-and-go script on a cleared scope" [Checked in: Comment 16] Pushed changeset 7e47bbbebc28 to mozilla-central.

I asked dmandelin on IRC and he said that he put those calls to stopSearch because the OSX64debug builds failed. Certainly I can't reproduce the failures on Windows. We have a number of options: 1. Push a test backout to try to see if any debug builds still fail (feel free to do release builds too, but I don't expect them to fail). 2. As 1, but increase the timeout of the cleanup block to 100s. 3. Condition the calls on existence or wrap them in try/catch. 4. Add some ugly code to autocomplete.xml to simulate a controller.

(In reply to comment #17) > I asked dmandelin on IRC and he said that he put those calls to stopSearch > because the OSX64debug builds failed. Certainly I can't reproduce the failures > on Windows. We have a number of options: > 1. Push a test backout to try to see if any debug builds still fail > (feel free to do release builds too, but I don't expect them to fail). > 2. As 1, but increase the timeout of the cleanup block to 100s. > 3. Condition the calls on existence or wrap them in try/catch. > 4. Add some ugly code to autocomplete.xml to simulate a controller. #1 seems the best to me, and failing that, #3. But I know little about this code so don't accord my opinion much weight.

Comment on attachment 514162 [details] [diff] [review] (Av1) Fix for "An error occurred - attempt to run compile-and-go script on a cleared scope" [Checked in: Comment 16] http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1298589076.1298592099.10983.gz Linux comm-central-trunk debug test mochitest-other on 2011/02/24 15:11:16 Comment 7 additional failures are V.Fixed :-) Ftr, they were counted as +/- 50 failures whereas logs listed +/- 10 errors only... (wrt bug 451287)

(In reply to comment #17) > 1. Push a test backout to try to see if any debug builds still fail > (feel free to do release builds too, but I don't expect them to fail). > 2. As 1, but increase the timeout of the cleanup block to 100s. Submitted: http://tbpl.mozilla.org/?tree=MozillaTry&rev=3903bb34d218 http://tbpl.mozilla.org/?tree=MozillaTry&rev=e3c50a937d2d

If 1. doesn't work, then maybe the correct fix is for toolkit autocomplete to stop the search when it is destroyed.

This option 1 fix succeeded as http://tbpl.mozilla.org/?tree=MozillaTry&rev=3b35034b050f Ftr, option 2 fix succeeded too as http://tbpl.mozilla.org/?tree=MozillaTry&rev=e4836345d9ea Rename test_autocomplete.xul to make it more explicit why it runs on mac only.

Comment on attachment 515266 [details] [diff] [review] (Bv1) Remove calls to Firefox stopSearch(), Rename test_autocomplete.xul to test_autocomplete_cocoa.xul Better would be to be more specific with the filename since the test is checking caret position in autocomplete widgets: test_autocomplete_mac_caret.xul I'm ok with removing the calls to stopSearch but what has changed between when they were added? The autocomplete tests have always had some intermittent problems that cause later tests to fail inexplicably.

(In reply to comment #23) > test_autocomplete_mac_caret.xul I'll rename it before checking it in. > I'm ok with removing the calls to stopSearch but what has changed between when No idea. And no details about the initial issue. (See comment 17.) > they were added? The autocomplete tests have always had some intermittent > problems that cause later tests to fail inexplicably. Hum, that should be an separate/explicit bug...

Comment on attachment 515266 [details] [diff] [review] (Bv1) Remove calls to Firefox stopSearch(), Rename test_autocomplete.xul to test_autocomplete_cocoa.xul Ping for review.

Comment on attachment 515266 [details] [diff] [review] (Bv1) Remove calls to Firefox stopSearch(), Rename test_autocomplete.xul to test_autocomplete_cocoa.xul Ping for review.

Maybe he's expecting a new patch?

Bv1, with comment 23 suggestion(s).

Comment on attachment 576327 [details] [diff] [review] (Bv1a) Remove calls to Firefox stopSearch(), Rename test_autocomplete.xul to test_autocomplete_mac_caret.xul [Checked in: Comment 31] OK, but let's watch to look for this failing again.

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1322504054.1322507762.12447.gz OS X 10.6 comm-central-trunk debug test mochitest-other on 2011/11/28 10:14:14 V.Fixed :-) (And Firefox is still passing.) To summarize: patch Av1 fixed bug 630072 regression in Gecko 2.0 cycle :-) patch Bv1a fixed bug 611652 regression (at last) in Gecko 11 cycle: these tests had been failing for SeaMonkey in the meantime.

(In reply to Serge Gautherie (:sgautherie) from comment #32) > patch Bv1a fixed bug 611652 regression (at last) in Gecko 11 cycle Arf, bug 611653!

Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/df201099745c Fix for "An error occurred - attempt to run compile-and-go script on a cleared scope" r=IanN a=beltzner NPOTB