Closed
Bug 632605
Opened 14 years ago
Closed 14 years ago
Fix timestamps for comment data submitted to ElasticSearch
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgriffin, Unassigned)
Details
Attachments
(1 file)
(deleted),
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
In working on a patch for bug 601743, I discovered I needed to change a little bit of the data that tbpl posts to ElasticSearch for comments. Specifically, I need to use UTC for the 'date' field, to prevent us from getting a date in some random locale, and I need to add a 'timestamp' field, which is the time that the comment was submitted.
Reporter | ||
Comment 1•14 years ago
|
||
Attachment #510828 -
Flags: review?(mstange)
Reporter | ||
Updated•14 years ago
|
Assignee: nobody → jgriffin
Comment 2•14 years ago
|
||
Comment on attachment 510828 [details] [diff] [review]
patch
(In reply to comment #0)
> and I need to add a 'timestamp' field, which is the time that
> the comment was submitted.
What's the advantage of taking the current time here instead of on the woo server side?
Attachment #510828 -
Flags: review?(mstange) → review+
Reporter | ||
Comment 3•14 years ago
|
||
(In reply to comment #2)
>
> What's the advantage of taking the current time here instead of on the woo
> server side?
No advantage; but since I needed to adjust this code to generate a UTC date for the startTime, I decided to add the timestamp here.
Pushed as http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/c929a1420853
Assignee: jgriffin → nobody
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Product: Webtools → Tree Management
Assignee | ||
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•