Ok, build1 of SeaMonkey 2.1beta2 encountered problems on the update generation [verification]. Basically our partial and complete uploads were failing to remove directories, which the update manifests should have properly ignored, this occurred [after investigation] due to not identifying these directories as actually being directories. A '/' at the end of the line accounts for it. c.f. |ignoring remove instruction for directory: greprefs/| which is echoed near the end of the make of update-packaging. ewong has graciously accepted this bug over IRC, since I am too overtired to have any confidence in it. when this lands, please land on both comm-central default branch and comm-central |COMM20b11_20110203_RELBRANCH| as well, so I can hopefully get our build2 out for testing within 24 hours of this bug being filed.

Comment on attachment 510928 [details] [diff] [review] Fixed paths in removed-files.in. my skim looks good, I won't trust a real review from myself until I've rested, maybe KaiRo can get to this faster though

Comment on attachment 510928 [details] [diff] [review] Fixed paths in removed-files.in. I filtered removed-files.in content out and that's what remained ;-) r+, if I may.

Comment on attachment 510928 [details] [diff] [review] Fixed paths in removed-files.in. I trust you haven't missed any, and those that are there look good. Serge, as much as I like you taking a look at it, I don't think you are a peer of the build system yet, so it's better if this has my (or Callek's) stamp on it.

(In reply to comment #4) > Comment on attachment 510928 [details] [diff] [review] > Fixed paths in removed-files.in. > > I trust you haven't missed any, and those that are there look good. I'm uncertain on the Mac ones though. That DefaultPlugin here looks suspicious: http://mxr.mozilla.org/comm-central/source/suite/installer/removed-files.in#217

(In reply to comment #4) > Comment on attachment 510928 [details] [diff] [review] > Fixed paths in removed-files.in. > > I trust you haven't missed any, and those that are there look good. And this line confuses me: http://mxr.mozilla.org/comm-central/source/suite/installer/removed-files.in#130

(In reply to comment #5) > I'm uncertain on the Mac ones though. That DefaultPlugin here > looks suspicious: > http://mxr.mozilla.org/comm-central/source/suite/installer/removed-files.in#217 I *think* that's a file. (In reply to comment #6) > And this line confuses me: > > http://mxr.mozilla.org/comm-central/source/suite/installer/removed-files.in#130 Mac has "app bundles" inside directories - those (.app or even .plugin) *look* like files even in the "Finder" file browser on the machine, but in reality are directories. So this one is correct.

(In reply to comment #7) > > http://mxr.mozilla.org/comm-central/source/suite/installer/removed-files.in#217 > > I *think* that's a file. Fwiw, this one should be the same (either way) as 202 ../Plug-Ins/PrintPDE.plugin/Contents/MacOS/PrintPDE and I too assumed they are (the) files. (Though I know nothing about OSX.)

Pushed to comm-central COMM20b11_20110203_RELBRANCH http://hg.mozilla.org/comm-central/rev/402a29ffb09b Pushed to comm-central default http://hg.mozilla.org/comm-central/rev/5dfe22893e47 Leaving to drivers to close.