Closed
Bug 633308
Opened 14 years ago
Closed 14 years ago
Add toString method to various Panorama objects
Categories
(Firefox Graveyard :: Panorama, defect, P4)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 5
People
(Reporter: mitcho, Assigned: mitcho)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
iangilman
:
review+
dveditz
:
approval2.0-
|
Details | Diff | Splinter Review |
When developing tests, we often see failures like "Got [object Object], expected [object Object]" which is not particularly helpful. We need TabItem, GroupItem, and perhaps other objects to have custom toString methods with some minimally identifying debug information.
Updated•14 years ago
|
Priority: -- → P4
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → mitcho
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #515356 -
Attachment is obsolete: true
Attachment #515357 -
Flags: review?(ian)
Attachment #515356 -
Flags: review?(ian)
Updated•14 years ago
|
Attachment #515357 -
Flags: review?(ian) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #515357 -
Flags: approval2.0?
Assignee | ||
Comment 3•14 years ago
|
||
Note to approvers: This is purely the addition of toString methods to our objects which will help us track down objects when debugging tests. Pushed to try just in case: http://tbpl.mozilla.org/?tree=MozillaTry&rev=fd11ee14cb24
Comment 5•14 years ago
|
||
Comment on attachment 515357 [details] [diff] [review] Patch v1.1 I love making tests easier to write, but this can land after FF4, doesn't need to add to the FF4 pile.
Attachment #515357 -
Flags: approval2.0? → approval2.0-
Assignee | ||
Updated•14 years ago
|
Attachment #515357 -
Flags: approval2.0- → approval2.0?
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f95cccd25069
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: Future → Firefox4.2
Comment 8•14 years ago
|
||
Comment on attachment 515357 [details] [diff] [review] Patch v1.1 minusing for mozilla2.0 again: this isn't fixing a user-facing regression or security bug so we don't see why this can't wait for FF5
Attachment #515357 -
Flags: approval2.0? → approval2.0-
Updated•14 years ago
|
Target Milestone: Firefox5 → Firefox 5
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•