Closed
Bug 633337
Opened 14 years ago
Closed 14 years ago
pattern viewBoxes still not treated correctly
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: longsonr, Assigned: longsonr)
References
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → longsonr
Attachment #511527 -
Flags: review?(jwatt)
|
|
Assignee | |
Comment 2•14 years ago
|
||
With this http://dev.w3.org/SVG/profiles/1.1F2/test/svg/pservers-pattern-04-f.svg displays correctly.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 511527 [details] [diff] [review]
patch
pservers-pattern-02 seems to be failing on how viewBoxes are interpreted too so I'll see if I can fix that too.
Attachment #511527 -
Flags: review?(jwatt)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Only fixes pservers-pattern-04, looks like pservers-pattern-02 is some other issue
Attachment #511527 -
Attachment is obsolete: true
Attachment #512022 -
Flags: review?(jwatt)
|
|
Assignee | |
Comment 5•14 years ago
|
||
|
||
Comment 7•14 years ago
|
||
Do you understand the use of MaxExpansion, Robert?
|
|
Assignee | |
Comment 8•14 years ago
|
||
bug 384208. If a pattern is rotated then the bounding box can be bigger. Probably should try to convert one of the testcases from that bug into a reftest.
|
|
||
Comment 9•14 years ago
|
||
The MaxExpansion call is in the |else|, so it's used for patternContentUnits=userSpaceOnUse, not =objectBoundingBox.
I have to prepare for the SVG WG F2F tomorrow (taking place all next week), and since we're going to have to wait until after ff4 to land this anyways, I'll come back to this after the F2F.
|
|
Assignee | |
Comment 10•14 years ago
|
||
Why are you worried about the MaxExpansion call? I haven't changed that.
|
|
||
Updated•14 years ago
|
Attachment #512023 -
Flags: review+
|
|
||
Comment 11•14 years ago
|
||
Because I needed to understand the surrounding code and how the function works and is used as a whole to understand the change.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #512022 -
Flags: review?(jwatt)
|
|
Assignee | |
Comment 12•14 years ago
|
||
Attachment #512022 -
Attachment is obsolete: true
Attachment #512023 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 13•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
|
|
Assignee | |
Updated•13 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•