Closed
Bug 633360
Opened 14 years ago
Closed 14 years ago
Tab bar's toolbar/scroll button borders overlap nav bar
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 4.0b12
People
(Reporter: fryn, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(2 files, 2 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
fryn
:
review+
shorlander
:
ui-review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
In all Windows 7 themes that I've tested (Aero, Basic, Classic), the tab bar's toolbar button :hover borders and scroll button borders (and border effects) overlap the nav bar by 1px.
In non-maximized mode of Aero, the scroll buttons' border effects extend an additional pixel, so the bug becomes much more visible. This additional pixel is due to:
>#main-window[sizemode=normal]:not([inFullscreen=true]) #TabsToolbar[tabsontop=true]:not(:-moz-lwtheme),
>#main-window[sizemode=normal]:not([inFullscreen=true])[disablechrome] #TabsToolbar {
> margin-bottom: -1px;
I would consider at least the latter issue (the additional pixel) to be definitely worth fixing for Firefox 4.
Reporter | ||
Updated•14 years ago
|
Keywords: regression
Comment 1•14 years ago
|
||
this makes the appearance perfect, but those are probably the longest selectors I have ever seen :(
Possible alternative could be to just set the 1px bottom border on the original -moz-border-image, is perfect in normal mode, when maximized the difference is really really faint (the line is detached 1px from the border, but doesn't look bad)
Comment 2•14 years ago
|
||
The other approach.
Feel free to throw these away if they are useless :)
Assignee | ||
Comment 3•14 years ago
|
||
The real problem is that the buttons have negative vertical margins, to prevent them from increasing the tab bar height. I can probably work around it in this case, but it would be better if the margins weren't needed in the first place.
Assignee: nobody → dao
Assignee | ||
Comment 4•14 years ago
|
||
Actually, I think I'm going to just get rid of the toolbar button appearance to avoid the hack altogether...
Assignee | ||
Comment 5•14 years ago
|
||
Attachment #511606 -
Attachment is obsolete: true
Attachment #511607 -
Attachment is obsolete: true
Attachment #511898 -
Flags: ui-review?(shorlander)
Attachment #511898 -
Flags: review?(fryn)
Reporter | ||
Comment 6•14 years ago
|
||
Comment on attachment 511898 [details] [diff] [review]
patch
Could we use this same scaleX(-1) technique to remove the need for tab-arrow-right.png and the right half of tab-overflow-border.png in pinstripe and gnomestripe too?
Assignee | ||
Comment 7•14 years ago
|
||
Pinstripe, probably yes. Gnomestripe uses native scroll arrows which I wouldn't want to mess with.
Reporter | ||
Comment 8•14 years ago
|
||
Could we use the background-image: -moz-linear-gradient(...); background-size: 1px 100%; technique to eliminate the need for tab-overflow-border.png entirely?
Assignee | ||
Comment 9•14 years ago
|
||
Yes. Could be done in a follow-up bug.
Reporter | ||
Comment 10•14 years ago
|
||
Comment on attachment 511898 [details] [diff] [review]
patch
Looks good to me.
Attachment #511898 -
Flags: review?(fryn) → review+
Comment 12•14 years ago
|
||
Comment on attachment 511898 [details] [diff] [review]
patch
This looks good! :)
Attachment #511898 -
Flags: ui-review?(shorlander) → ui-review+
Assignee | ||
Updated•14 years ago
|
Attachment #511898 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #511898 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 13•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
Comment 14•14 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110216 Firefox/4.0b12pre
Verified issue and it's no longer present.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•