Closed
Bug 633408
Opened 14 years ago
Closed 14 years ago
32bit Firefox failed to start on a machine with 16GB (or 32GB ...) memory
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
(Keywords: regression, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
(deleted),
patch
|
gal
:
review+
gal
:
approval2.0+
|
Details | Diff | Splinter Review |
This bug is found on a Solaris/SPARC machine with 16GB memory.
I think it is valid for all platforms.
In xpcjsruntime.cpp, we have
1468 JS_SetNativeStackQuota(cx, 128 * sizeof(size_t) * 1024);
1469 PRInt64 totalMemory = PR_GetPhysicalMemorySize();
1470 JS_SetScriptStackQuota(cx, PR_MAX(25 * sizeof(size_t) * 1024 * 1024,
1471 totalMemory / 4));
JS_SetScriptStackQuota takes size_t for quota.
So if we have 16GB memory, we're actually setting quota to zero.
|
||
Comment 1•14 years ago
|
||
Not a blocker, but we take an approved patch. Almost nobody has that much RAM. You patch, I review and approve?
blocking2.0: ? → -
|
|
||
Updated•14 years ago
|
what about this one?
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 511587 [details] [diff] [review]
patch
Looks good. The problem is really the PRInt64 totalMemory.
Attachment #511587 -
Flags: review?(gal)
Attachment #511587 -
Flags: review+
Attachment #511587 -
Flags: approval2.0+
http://hg.mozilla.org/tracemonkey/rev/bc906595cef3
Sorry I made a typo in commit message. :(
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•14 years ago
|
||
Model Name: Mac Pro
Processor Name: Quad-Core Intel Xeon
Processor Speed: 3 GHz
Memory: 16 GB
MAC OS X: 10.6.6
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11) Gecko/20100101 Firefox/4.0b11
64bit runs fine. 32bit fails to launch.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•