(not reading, please use seth@sspitzer.org instead) Reporter
	Description • 24 years ago

talking with racham, we notice a bunch of this in our mailnews js:

if (serverType == "nntp")
serverType != 'imap';
etc.

what we should be doing is moving the logic into the incoming server
implementations.

for example, if the point of doing the check is to determine if we should call
"perform expand" on a server on startup, we should add performExpandOnStartup as
a boolean attribute on nsIMsgIncomingServer, have the base class return
PR_FALSE, and have nsNntpIncomingServer.cpp override GetPerformExpandOnStartup()
and return PR_TRUE.

we have a ton of places where we could do this sort of cleanup, in our front end
and back end code.

	Sheela Ravindran
	Comment 1 • 24 years ago

change qa contact karen
Karen,
if not your area, reassign

	Arun Prasannan (polar)
	Comment 2 • 16 years ago

This bug is being marked EXPIRED as it has seen no activity in a very long time.

If you think that the issue reported might still be relevant, please test with a recent release of SeaMonkey and if the problem persists feel free to re-open the report. Thank you.

http://www.seamonkey-project.org/

	Mark Banner (:standard8)
	Comment 3 • 16 years ago

Bulk reopening incorrectly expired bugs - no activity does not constitute no bug - these need proper checking.

	Serge Gautherie (:sgautherie)
	Comment 4 • 15 years ago

Ftr:
M.C.: "Found 18 matching lines in 7 files"
http://mxr.mozilla.org/comm-central/search?string=serverType+%28%21%7C%3D%29%5C%3D&regexp=on&find=%2Fmail%2F.*%5C.js%24
TB: "Found 4 matching lines in 3 files"
http://mxr.mozilla.org/comm-central/search?string=serverType+%28%21%7C%3D%29%5C%3D&regexp=on&find=%2Fsuite%2F.*%5C.js%24
SM: "Found 19 matching lines in 6 files"

	:aceman
	Comment 5 • 12 years ago

This would be nice.
There are also occurences in AccountManager.js which the mxr search does not show and new are cropping up due to the new "IM" account type that lacks many capabilities (spun off to bug 739908).