Closed
Bug 633891
Opened 14 years ago
Closed 14 years ago
nsGlobalWindow.cpp:6430: warning: unused variable 'cx' (remove unused variable)
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
WORKSFORME
mozilla6
People
(Reporter: dholbert, Assigned: Ms2ger)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
As noted in bug 621764 comment 22, that bug's checkin introduced this warning, from an unused variable:
> dom/base/nsGlobalWindow.cpp: In member function 'virtual void nsGlobalWindow::LeaveModalState(nsIDOMWindow*)':
> dom/base/nsGlobalWindow.cpp:6430: warning: unused variable 'cx'
Code:
> 6430 JSContext *cx = nsContentUtils::GetCurrentJSContext();
dolske tells me over email that this line was left over from an earlier patch incarnation, and it now wants to just be removed.
|
||
Updated•14 years ago
|
Whiteboard: [build_warning] → [build_warning] [good first bug]
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [build_warning] [good first bug] → [build_warning][needs review]
|
||
Comment 2•14 years ago
|
||
Comment on attachment 518012 [details] [diff] [review]
Patch v1
Oops. This is is already taken care of by the patch in bug 635888, which is just waiting for the tree to reopen.
r+ except for that. ;-)
Attachment #518012 -
Flags: review?(dolske)
|
|
||
Updated•14 years ago
|
Depends on: 635888
Whiteboard: [build_warning][needs review] → [build_warning]
|
|
Assignee | |
Comment 3•14 years ago
|
||
That works too. Thanks.
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
Target Milestone: --- → mozilla6
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•