Closed
Bug 634439
Opened 14 years ago
Closed 14 years ago
make package: "Warning: package error or possible missing or unnecessary file: bin/components/suitebrowser.xpt (package-manifest, 171)."
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.1b3
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
Affected builds: build + leak + nightly.
This was missed in bug 621532.
Flags: in-testsuite-
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #512623 -
Flags: review?(bugspam.Callek)
|
||
Updated•14 years ago
|
Attachment #512623 -
Flags: review?(bugspam.Callek) → review+
|
|
||
Updated•14 years ago
|
Attachment #512623 -
Flags: review+ → review-
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 512623 [details] [diff] [review]
(Av1) Remove obsolete suitebrowser.*
SuiteBrowser.manifest needs to stay.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Av1, with comment 2 suggestion(s).
(In reply to comment #2)
> SuiteBrowser.manifest needs to stay.
I had removed it +/- "optimistically".
Could you teach me why it's still needed?
(I should have asked before, sorry.)
Attachment #512623 -
Attachment is obsolete: true
Attachment #513126 -
Flags: review?(bugspam.Callek)
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 513126 [details] [diff] [review]
(Av2) Stop packaging obsolete suitebrowser.xpt
[Checked in: Comment 5]
Suitebrowser.manifest needs to stay because it still exists and does more things.
http://mxr.mozilla.org/comm-central/source/suite/browser/SuiteBrowser.manifest
the .xpt is able to go away because we are no longer creating an idl to use here.
Attachment #513126 -
Flags: review?(bugspam.Callek) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Comment on attachment 513126 [details] [diff] [review]
(Av2) Stop packaging obsolete suitebrowser.xpt
[Checked in: Comment 5]
http://hg.mozilla.org/comm-central/rev/dc1fe50d0940
Attachment #513126 -
Attachment description: (Av2) Stop packaging obsolete suitebrowser.xpt → (Av2) Stop packaging obsolete suitebrowser.xpt
[Checked in: Comment 5]
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•14 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1298316085.1298325448.15092.gz&fulltext=1
WINNT 5.2 comm-central-trunk build on 2011/02/21 11:21:25
V.Fixed
Status: RESOLVED → VERIFIED
|
|
Assignee | |
Comment 7•14 years ago
|
||
(In reply to comment #4)
> Suitebrowser.manifest needs to stay because it still exists
Ah, sure, I missed to check that :-<
|
|
Assignee | |
Updated•13 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•