Closed
Bug 634773
Opened 14 years ago
Closed 12 years ago
CSPUtils incorrectly compares two CSPSourceLists - *.equals('none') returns true
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: bsterne, Assigned: geekboy)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
CSPSourceList.prototype.equals compares two source lists by doing two checks:
1. their length is equal
2. each of the items in the sorted list of sources is equal
This causes * and 'none' to be considered equal because they both have an empty internal source list.
Fixing this bug is trivial. It is, however, hiding a bug in content/base/test/unit/test_bug558431.js. Only that test has the bug, NOT the feature it's testing, so we don't need to worry about fixing this for Firefox 4. I'll file a follow-up bug to fix that test.
|
Reporter | |
Comment 1•14 years ago
|
||
|
Assignee | |
Updated•12 years ago
|
Assignee: brandon → sstamm
|
|
Assignee | |
Comment 2•12 years ago
|
||
unbitrotted trivial fix and added test cases. jst: this is literally a three line fix (two that matter), touching only CSPUtils.jsm. Can you take a quick look?
Attachment #512965 -
Attachment is obsolete: true
Attachment #628889 -
Flags: review?(jst)
|
||
Updated•12 years ago
|
Attachment #628889 -
Flags: review?(jst) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pushed to inbound.
https://hg.mozilla.org/integration/mozilla-inbound/rev/829e55e4ff61
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla15
|
||
Updated•12 years ago
|
Target Milestone: mozilla15 → mozilla16
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•