Jesse Ruderman Reporter
	Description • 14 years ago

1. Enable accessibility, e.g. by pasting the following into the js console:

Components
  .classes["@mozilla.org/accessibilityService;1"]
  .getService(Components.interfaces.nsIAccessibleRetrieval);

2. Load the testcase.

Result: Null deref crash [@ nsAccessNode::GetContent]

	Jesse Ruderman Reporter
	Comment 2 • 14 years ago

bp-45f45514-9051-4231-ad0d-c24242110218 [@ nsDocAccessible::AddDependentIDsFor]

There are 6 other crash reports for this signature, all from Firefox 4 Beta 11.

	alexander :surkov (:asurkov) Assignee
	Comment 4 • 14 years ago

http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/surkov.alexander@gmail.com-807c4483e114

	Fernando Herrera
	Comment 5 • 14 years ago

Comment on attachment 513938 [details] [diff] [review]
allow relation on document accessible defined on document content

Checked the crash and the Fix. Good catch!

The patch it's ok.

Open nit question. Do you think this:

>-    if (accessible)
>-      RemoveDependentIDsFor(accessible, aAttribute);
>+    if (!accessible) {
>+      if (aElement != mContent)
>+        return;
>+
>+      accessible = this;
>+    }
>+    RemoveDependentIDsFor(accessible, aAttribute);
>   }
> }

would be more clear like this?:

    if (accessible)
      RemoveDependentIDsFor(accessible, aAttribute);
    else îf (aElement == mContent)
      RemoveDependentIDsFor(this, aAttribute);
    
I had to double think when I read the "accessible = this" line :).

regardless, r=me

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 6 • 14 years ago

Comment on attachment 513938 [details] [diff] [review]
allow relation on document accessible defined on document content

a=me with fer's nit addressed.

	alexander :surkov (:asurkov) Assignee
	Comment 7 • 14 years ago

landed with Fernando's comment addressed - http://hg.mozilla.org/mozilla-central/rev/478422d2a964

	alexander :surkov (:asurkov) Assignee
	Comment 8 • 14 years ago

(In reply to comment #7)
> landed with Fernando's comment addressed -
> http://hg.mozilla.org/mozilla-central/rev/478422d2a964

Gecko 2.0 (fx4b12)