Closed
Bug 635442
Opened 14 years ago
Closed 14 years ago
Crash [@ nsSVGComponentTransferFunctionElement::DidAnimateNumberList]
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: jruderman, Assigned: longsonr)
References
Details
(Keywords: crash, regression, testcase)
Crash Data
Attachments
(3 files)
|
(deleted),
image/svg+xml
|
Details | |
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
dholbert
:
review+
shaver
:
approval2.0+
|
Details | Diff | Splinter Review |
testcase (crashes Firefox when loaded)
Based on layout/reftests/svg/smil/anim-feFuncR-tableValues-01.svg
|
Reporter | |
Comment 1•14 years ago
|
||
|
Assignee | |
Comment 2•14 years ago
|
||
I'll turn the testcase into a crashtest.
Assignee: nobody → longsonr
Attachment #513797 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Boris, this also affects nsSVGUtils::GetParentElement
|
|
Assignee | |
Updated•14 years ago
|
Keywords: regression
|
|
Assignee | |
Updated•14 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
|
||
Comment 4•14 years ago
|
||
Comment on attachment 513797 [details] [diff] [review]
patch
>diff --git a/content/svg/content/src/nsSVGFilters.cpp b/content/svg/content/src/nsSVGFilters.cpp
>+inline static void DidAnimateAttrViaParent(Element *aFilterPrimitive) {
Nit: Perhaps insert a newline just before the function name, to match general mozilla style for function-definitions in .cpp files?
r=dholbert
Attachment #513797 -
Flags: review?(dholbert) → review+
|
|
||
Updated•14 years ago
|
Flags: in-testsuite?
|
||
Updated•14 years ago
|
Attachment #513797 -
Flags: approval2.0?
|
|
||
Comment 5•14 years ago
|
||
Can this be approved for 2.0?
Attachment #513797 -
Flags: approval2.0? → approval2.0+
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 6•14 years ago
|
||
I did not fix the code style thing in comment 4 before pushing since the file itself doesn't seem to be consistent, and previous helpers are using same style as this one. Maybe you want a separate bug to fix code style in this file.
http://hg.mozilla.org/mozilla-central/rev/914d4d888c72
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
|
|
||
Comment 7•14 years ago
|
||
Thanks! Yeah, that style nit isn't worth filing a bug on. :) It's fine as-is.
|
||
Updated•14 years ago
|
Crash Signature: [@ nsSVGComponentTransferFunctionElement::DidAnimateNumberList]
You need to log in
before you can comment on or make changes to this bug.
Description
•