Closed
Bug 635792
Opened 14 years ago
Closed 14 years ago
Fix debugQATextEditorShell so that it works
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b3
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
I noticed whilst working on another bug that debugQATextEditorShell was fairly broken. This patch fixes the majority of the issues - the observer adding/removal issue will be dealt with in bug 606683 (or a related bug).
Attachment #514098 -
Flags: review?(neil)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 514098 [details] [diff] [review]
Fix texteditor patch v0.1
>+ toggletoolbar="true"
>+ lightweightthemes="true"
>+ lightweightthemesfooter="status-bar"
Oops.
|
||
Comment 2•14 years ago
|
||
Comment on attachment 514098 [details] [diff] [review]
Fix texteditor patch v0.1
> function ShowHideToolbarSeparators(toolbar) {
>+ // Make sure the toolbar actually exists.
>+ if (!toolbar)
>+ return;
This is all going away with custom toolbars right? r=me if it is.
> <!-- tasks menu filled from tasksOverlay -->
>- <menu accesskey="t" id="tasksMenu"/>
>+ <menu id="tasksMenu"/>
>
> <!-- help menu filled from globalOverlay -->
>- <menu accesskey="h" id="menu_Help"/>
>+ <menu id="menu_Help"/>
I don't suppose you could include the window menu while you're there?
Attachment #514098 -
Flags: review?(neil) → review+
(In reply to comment #2)
> Comment on attachment 514098 [details] [diff] [review]
> Fix texteditor patch v0.1
>
> > function ShowHideToolbarSeparators(toolbar) {
> >+ // Make sure the toolbar actually exists.
> >+ if (!toolbar)
> >+ return;
> This is all going away with custom toolbars right? r=me if it is.
Yes, it will be.
> > <!-- tasks menu filled from tasksOverlay -->
> >- <menu accesskey="t" id="tasksMenu"/>
> >+ <menu id="tasksMenu"/>
> >
> > <!-- help menu filled from globalOverlay -->
> >- <menu accesskey="h" id="menu_Help"/>
> >+ <menu id="menu_Help"/>
> I don't suppose you could include the window menu while you're there?
Done.
As checked in.
http://hg.mozilla.org/comm-central/rev/c187bbef92f4
Attachment #514098 -
Attachment is obsolete: true
Attachment #514298 -
Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
You need to log in
before you can comment on or make changes to this bug.
Description
•