Closed
Bug 636495
Opened 14 years ago
Closed 14 years ago
Make enabling profilers actually --enable-profiling
Categories
(Firefox Build System :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ted
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Patch coming up.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #514828 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [need review]
|
||
Updated•14 years ago
|
Attachment #514828 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [need review] → [need approval]
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 514828 [details] [diff] [review]
Make sure --enable-shark actually enables profiling.
This should be very safe, and make our shark builds actually usable.
Attachment #514828 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #514828 -
Flags: approval2.0? → approval2.0+
|
||
Comment 3•14 years ago
|
||
I'd keep valgrind and callgrind together. Either move one up or leave the other where it is.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Oh, and the point is that the code that _checked_ MOZ_PROFILING used to come before the places that set it for the profilers. The patch just fixes that.
Pushed as http://hg.mozilla.org/mozilla-central/rev/de0e9f27b608
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [need approval]
Target Milestone: --- → mozilla2.0
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•