Closed
Bug 63650
Opened 24 years ago
Closed 23 years ago
Default line-height should be 1.1 or 1.2em for Japanese font
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
VERIFIED
FIXED
Future
People
(Reporter: kazhik, Assigned: shanjian)
References
Details
(Whiteboard: WONTFIX?)
Attachments
(3 files)
It looks like default line-height is 1.0em, but it's not enough
for Japanese font. It should be 1.1em or 1.2em.
The CSS1 specification says "A value of 'normal' sets the
'line-height' to a reasonable value for the element's font.
It is suggested that UAs set the 'normal' value to be a
number in the range of 1.0 to 1.2".
http://www.w3.org/TR/REC-CSS1#line-height
This problem was reported on Bugzilla-jp.
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=537
Reporter | ||
Comment 1•24 years ago
|
||
Comment 2•24 years ago
|
||
Since erik's dealt with line-height and font-size issues in the past, giving to
erik, cc: buster and me.
Assignee: clayton → erik
Comment 3•24 years ago
|
||
KOIKE: Your commet seems pretty subjective. IS there any document/specification/
standard support your opinion ? cc pierre. Pierre: where is the place we can
control the value of normal in mozilla ? I am not suggest we should change it
right away, but it will be nice ot know where it is. This is a style system
issue. Change the component to Stylesystem
Assignee: erik → pierre
Component: Layout → Style System
QA Contact: petersen → chrisd
Target Milestone: --- → Future
Comment 4•24 years ago
|
||
What if we used 'normal' to include the external leading to rather than just the
internal leading? Do these Japanese fonts have appropriate external leading in
the font metrics? Would that break other content? (How badly? It seems like a
good thing to do, anyway...)
Comment 5•24 years ago
|
||
Times New Roman at 16px gives a tmHeight of 19px, and that's what WinNav4 and
WinIE use. The tmHeight value does not include the external leading, which is
1px (giving a total of 20px = 19 + 1).
So, if we changed WinMoz to include the external leading, our pages would look
different from the old browsers. In normal text, that might not be a problem,
but in forms and tables, these small effects have a way of multiplying several
fold. Ask Rod Spears. I'm sure he can give you some horror stories.
Last time I checked, the Japanese fonts had a tmHeight equal to the font size,
and the external leading was zero. (I may be wrong. Maybe somebody can check
this.)
Anyway, the only way to solve this problem is to come up with some hack for
Japanese (and other) fonts, leaving Times New Roman and other Western fonts as
they are. Such a hack would not be clean, since the fonts should be giving us
better leading values. But Mozilla has been known to perform dirty tricks every
now and then to get around legacy issues. Perhaps this is one of those areas.
Comment 6•24 years ago
|
||
Netscape's standard compliance QA team reorganised itself once again, so taking
remaining non-tables style bugs. Sorry about the spam. I tried to get this done
directly at the database level, but apparently that is "not easy because of the
shadow db", "plus it screws up the audit trail", so no can do...
QA Contact: chrisd → ian
Comment 7•24 years ago
|
||
I recommend we WONTFIX this. We already have a bug with 'line-height:normal'
being not quite the right height (or rather, 1.0 being not quite right).
Whiteboard: WONTFIX?
Reporter | ||
Comment 8•24 years ago
|
||
Ian, do you mean this is a duplicate of another bug? I can't find that.
Comment 9•24 years ago
|
||
KOIKE: no, I'm saying I do not think there is a valid bug here. The bug I was
referring to is bug 82422, which is related but is not quite the same issue.
Comment 10•24 years ago
|
||
I think this issue relates to the parenthetical comment I made in point (2) in
my comment a few minutes ago on bug 82422. But that raises the question -- do
these fonts have metrics that specify nonzero (and appropriate) recommended
leading? (I'm getting my terms all mixed up... but what I mean is if the
metrics have a recommended spacing that's larger than the maximum extension of
the characters.)
Comment 11•23 years ago
|
||
Comment 12•23 years ago
|
||
Comment 13•23 years ago
|
||
dbaron: I think the answer to your question is yes. I think this would affect
chinese fonts too. See the testcase with colored top and bottom borders
Assignee | ||
Comment 14•23 years ago
|
||
I am going to take care of this problem in 76097. Please assign this one to me.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 18•23 years ago
|
||
this has been fixed by 76097.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•