Closed
Bug 636569
Opened 14 years ago
Closed 14 years ago
'this.notifyStatus is not a function' when a crash report fails to submit
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jdm, Assigned: jdm)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mossop
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
I've got crash reports failing to submit in Fennec, and I see the subject appear in the error console. The problem line is here:
>354 let self = this;
>355 function loadHandler() {
>356 if (iframe.contentWindow.location == "about:blank")
>357 return;
>358 iframe.removeEventListener("load", loadHandler, true);
>359 if (!self.submitForm()) {
>360 this.notifyStatus(FAILED);
>361 self.cleanup();
>362 }
>363 }
The |this| looks out of place when everything else is using |self|.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #514896 -
Flags: review?(dtownsend)
|
||
Updated•14 years ago
|
Attachment #514896 -
Flags: review?(dtownsend)
Attachment #514896 -
Flags: review+
Attachment #514896 -
Flags: approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → josh
|
|
Assignee | |
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•