Closed
Bug 636764
Opened 14 years ago
Closed 14 years ago
Differentiate between exceptions and assertions for l10n tests
Categories
(Mozilla QA Graveyard :: Mozmill Result Dashboard, defect)
Mozilla QA Graveyard
Mozmill Result Dashboard
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
u279076
:
review+
|
Details | Diff | Splinter Review |
For l10n tests we have to differentiate between JUM assertions and exceptions. Otherwise some important information is not shown.
|
Assignee | |
Comment 1•14 years ago
|
||
Only for l10n tests for now because no other testrun is using the JUM lib.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #515108 -
Flags: review?(anthony.s.hughes)
Comment on attachment 515108 [details] [diff] [review]
Patch v1
>- failures.push(result.fails[j].comment);
>+ else
>+ failures.push("unknown failure");
In the case of !exception && !assertion, I'd still like to see the failure. "unknown failure" is not valuable. Can you simply use result.fails[j].comment for the "unknown fail" case?
With that change, r+.
Attachment #515108 -
Flags: review?(anthony.s.hughes) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #3)
> In the case of !exception && !assertion, I'd still like to see the failure.
> "unknown failure" is not valuable. Can you simply use result.fails[j].comment
> for the "unknown fail" case?
We do not have a result.fails[j].comment field anymore with the changes on bug 632403. We can really have only those two different types of failure. So there is really nothing I could change.
Depends on: 632403
|
|
Assignee | |
Comment 5•14 years ago
|
||
Anthony, any further objections? Otherwise I would like to land it.
|
|
Assignee | |
Comment 6•14 years ago
|
||
Due to no other objections I have pushed the change to all dashboard instances and landed the patch in the repository.
https://github.com/whimboo/mozmill-dashboard/commit/26436c6b2d435046cb36d14bb872e3866a6e762b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•