Closed
Bug 636788
Opened 14 years ago
Closed 14 years ago
Adapt Link Behavior pref pane after |Bug 583625 - Consider adding UI for pref browser.link.open_newwindow.restriction| and |Bug 505311 - SeaMonkey should default to tabbed browsing|
Categories
(SeaMonkey :: Help Documentation, defect)
SeaMonkey
Help Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b3
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
stefanh
:
review+
|
Details | Diff | Splinter Review |
The Link Behavior pref pane is outdated, see bug 583625 and bug 505311. I think our minimal goal for 2.1 should be up-to-date docs for Preferences, and I thought I might set a good example. Come one guys, we can do this! :-)
Hint: http://kb.mozillazine.org/Browser.link.open_newwindow.restriction (the order in our UI is 0, 2, 1)
Attachment #515135 -
Flags: review?(stefanh)
Comment 1•14 years ago
|
||
Comment on attachment 515135 [details] [diff] [review]
patch
+ <li><strong>Don't divert custom windows into tabs</strong>: Open
+ the page to be loaded in a popup window if the JavaScript call
+ included a features parameter, else open the page in a tab according
+ to the above settings. (This is the default.)</li>
This might be a bit too technical, I think. Perhaps something like this (you get the idea):
"Open a new window if the script includes information on how the new window should be displayed, else"
Or "Open a new window if the script have specified any features of the new window, else"
Also, I see that there's a lot of "This is the default". I don't think we need those, but if you feel strongly about it, feel free to leave them there. I just think that it might add a maintenance problem, since we don't know if we change the defaults in the future ;-)
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #515135 -
Attachment is obsolete: true
Attachment #515135 -
Flags: review?(stefanh)
Attachment #515461 -
Flags: review?(stefanh)
Comment 3•14 years ago
|
||
Comment on attachment 515461 [details] [diff] [review]
patch v2 [Checkin: comment 4]
+ the page to be loaded in a popup window if the script explicitly
+ specified features of the new window (such as size or position)
Should it really be "specified" (compare "open", "to be loaded")?
Attachment #515461 -
Flags: review?(stefanh) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 515461 [details] [diff] [review]
patch v2 [Checkin: comment 4]
http://hg.mozilla.org/comm-central/rev/1980c32b1afa
with tense comment 3 addressed
Attachment #515461 -
Attachment description: patch v2 → patch v2 [Checkin: comment 4]
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
You need to log in
before you can comment on or make changes to this bug.
Description
•