Closed
Bug 637032
Opened 14 years ago
Closed 14 years ago
Repeated Console messages in the Web Console not showing number
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rcampbell, Assigned: rcampbell)
References
Details
Attachments
(1 file)
(deleted),
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
in today's nightly, 2011-02-26, repeated console messages are not showing the numeric badge next to the item.
To reproduce:
1. Open a web console.
2. In the input line, enter:
for (let i = 0; i < 10; i++) console.log("hi");
3. Hit the enter key
You'll see:
[13:32:08.745] for (let i = 0; i < 10; i++) console.log("hi");
[13:32:08.753] "hi"
[13:32:08.767] undefined
You should see
[13:32:08.745] for (let i = 0; i < 10; i++) console.log("hi");
[13:32:08.753] "hi" (10)
[13:32:08.767] undefined
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
Wondered why this didn't show up in the unittests and discovered that I'd lost the addition to the makefile along the way. Re-added and fixed the console filtering.
Attachment #515360 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 2•14 years ago
|
||
passed a run through try here:
http://tbpl.mozilla.org/?tree=MozillaTry&rev=06235f2870f8
Comment 3•14 years ago
|
||
Comment on attachment 515360 [details] [diff] [review]
[checked-in] repeated-console
While I'm not comfortable reviewing this patch, it gets my stamp of pre-approval should someone convince Gavin to look at the one-liner. Looks safe to me!
Comment 4•14 years ago
|
||
Comment on attachment 515360 [details] [diff] [review]
[checked-in] repeated-console
r=sdwilsh
Attachment #515360 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Comment on attachment 515360 [details] [diff] [review]
[checked-in] repeated-console
http://hg.mozilla.org/mozilla-central/rev/9f426a5d89f5
Attachment #515360 -
Attachment description: repeated-console → [checked-in] repeated-console
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•