Closed
Bug 637446
Opened 14 years ago
Closed 14 years ago
Run jit-tests even if ENABLE_TRACEJIT isn't defined.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: paul.biggar, Assigned: paul.biggar)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fixed-in-tracemonkey])
Attachments
(1 file)
|
(deleted),
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
The jit-tests are predicated on ENABLE_TRACEJIT, though they work on all configurations I've tried. We should run them in all configs.
Attachment #515727 -
Flags: review?(nnethercote)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 515727 [details] [diff] [review]
Test on all configs, not just ENABLE_TRACEJIT.
Fine by me so long as it doesn't cause failures. Though it looks like that patch is on top of some other changes in your tree? Eg. you have JITFLAGS defined, which isn't in TM, but is in the patch I have in bug 635155, but I don't have the ',' at the start.
Attachment #515727 -
Flags: review?(nnethercote) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Yup, it's on top of bug 637390 (which itself is based on bug 635155).
|
|
||
Comment 3•14 years ago
|
||
Oh, I should read all my bugmail before commenting... I see now this is on top of bug 637390.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Whiteboard: [fixed-in-tracemonkey]
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•