This is kind of a followup to bug 569400 (even though it hasn't landed yet), but I didn't want to add more noise or blocking items to that bug. It would be neat with a bit of a border around the TB content.

This seems to only affect the Aero glass theme, so waiting until that's landed before I do any patches.

Andreas is this what where you aiming? This patch also fixes the transparent FindToolbar.

Perfect! I don't seem to get a border when I switch to the Vista basic appearance, but Firefox don't do that either, so perhaps that's ok.

Adds borders like FF around the content

Comment on attachment 521974 [details] [diff] [review] Patch Simple change, ui-r+

Comment on attachment 521974 [details] [diff] [review] Patch So, my problems with this are two-fold. First, we are still missing the border on the bottom, and we don't have the nicely rounded corners on the top like Firefox does. Second, adding a couple of extra vboxes just for the left and right borders seems really heavyweight… I think adding a border to #messengerBox should be able to take care of the bottom, left, and right sides, and then we'll need to mess with the tab bar to get it to draw to the edge, instead of stopping a few pixels before. (Images available upon request.) Thanks, Blake.

(In reply to comment #7) > flag: review?(bwinton@mozillamessaging.com) => review-Comment on attachment 521974 [details] [diff] [review] > Patch > > So, my problems with this are two-fold. > > First, we are still missing the border on the bottom, and we don't have the > nicely rounded corners on the top like Firefox does. The bottom border is made with the status-bar. Firefox is using the browser-bottombox for this. The rounded corners should be a other bug, but this isn't as easy as in Firefox because we have to apply the radii to mailContent, messengerBox, folderPaneBox and folderPaneHeader on the left side and on the right side the same down to the treecolpicker. A quick hack wasn't successful. > Second, adding a couple of extra vboxes just for the left and right borders > seems really heavyweight… Also this is the way Firefox has implemented this. > I think adding a border to #messengerBox should be able to take care of the > bottom, left, and right sides, and then we'll need to mess with the tab bar to > get it to draw to the edge, instead of stopping a few pixels before. Yes this is simpler, but this still needs the border styles on the status-bar. I'm not sure what you mean with the tab bar. > (Images available upon request.) Yes please ;)

Now only made with CSS. Works with status-bar enabled and disabled.

Comment on attachment 525778 [details] [diff] [review] Simpler approach without XUL Much simpler, much nicer. Now to see if we can get Firefox to do the same thing. ;) One thing I did notice was that on a dark background, the line above the status bar sticks out a pixel too far. Check out the highlighted bit in http://dl.dropbox.com/u/2301433/Screenshots/StatusBar.png to see what I mean. However, I believe you can fix that in a reasonable way without my help, so I'm going to say r=me with that fixed. And you've already gotten a ui-review from Andreas, so the next patch can just be marked [checkin-needed]. :) Thanks for all the work you've put in to this set of bugs, Blake.

Solved the problem with bar sticks out a pixel too far by giving a border-radius of 1px.

Checked in: http://hg.mozilla.org/comm-central/rev/177394b47589