Closed
Bug 639286
Opened 14 years ago
Closed 14 years ago
Replace thick transparent border on tabs with proper CSS padding
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 5
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
fryn
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #517245 -
Flags: review?(fryn)
|
||
Comment 5•14 years ago
|
||
Comment on attachment 517245 [details] [diff] [review]
patch
I haven't tested it, but the math is correct.
Attachment #517245 -
Flags: review?(fryn) → review+
Forgive me if this is the wrong place to comment on this, but does the tabs still need that border-radius since they are squared now? It causes this bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=624225
Removing the border-radius does not cause any difference to me, visually.
|
|
||
Comment 7•14 years ago
|
||
(In reply to comment #6)
It causes a difference in the corners. We need the background to overlap part but not all of the border. Bug 624225 will require a different fix.
|
|
Assignee | |
Comment 8•14 years ago
|
||
Whiteboard: fixed-in-cedar
|
||
Comment 9•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: --- → Firefox4.2
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: Firefox5 → Firefox 5
You need to log in
before you can comment on or make changes to this bug.
Description
•