Closed Bug 639799 Opened 14 years ago Closed 13 years ago

New icons for the tasks header

Categories

(Calendar :: Tasks, defect)

Product:
Calendar
Component:
Tasks
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: andreasn, Assigned: Fallen)

References

Details

(Whiteboard: [needed beta][no l10n impact])

Attachments

(2 files, 7 obsolete files)

Combined Patch - v3
(deleted), patch
Fallen
: review+
Details | Diff | Splinter Review
error on the priority button icon
(deleted), image/jpeg
Details
Attached patch tasks header icons (obsolete) (deleted) — — Splinter Review
Spinning off bug 470824 Here are some new icons for the tasks header
Attached image and the graphics (obsolete) (deleted) —
Really odd, the binary don't want to go into the patch. :/
Attachment #517719 - Attachment filename: calendar-header-icons → calendar-header-icons.diff
Attachment #517719 - Attachment is patch: true
Attachment #517719 - Attachment mime type: application/octet-stream → text/plain
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
Flags: blocking-calendar1.0+
Whiteboard: [needed beta][no l10n impact]
Attached patch new patch (do I get graphics?) (obsolete) (deleted) — — Splinter Review
Attached patch oops, wrong patch (obsolete) (deleted) — — Splinter Review
Attachment #519519 - Attachment is obsolete: true
Attached patch with graphics in the patch (obsolete) (deleted) — — Splinter Review
Attachment #519523 - Flags: ui-review?(clarkbw)
Attachment #519520 - Attachment is obsolete: true
Attachment #517719 - Attachment is obsolete: true
Attachment #517720 - Attachment is obsolete: true
The above patch depends on the patch in bug 641806
Comment on attachment 519523 [details] [diff] [review] with graphics in the patch >+ skin/calendar/tasks-actions.png (themes/@THEME@/images/tasks-actions.png) > skin/calendar/widgets/calendar-widgets.css (themes/@THEME@/widgets/calendar-widgets.css) Aside from that codewise r=philipp. Feel free to check in as soon as the dependent bug is fixed.
Attachment #519523 - Flags: review+
Whiteboard: [needed beta][no l10n impact] → [needed beta][no l10n impact][needs review]
Comment on attachment 519523 [details] [diff] [review] with graphics in the patch nice! simple and clean, I like your check mark
Attachment #519523 - Flags: ui-review?(clarkbw) → ui-review+
Keywords: checkin-needed
Whiteboard: [needed beta][no l10n impact][needs review] → [needed beta][no l10n impact][needs checkin]
Checked in: http://hg.mozilla.org/comm-central/rev/1d7afda228c8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needed beta][no l10n impact][needs checkin] → [needed beta][no l10n impact]
Target Milestone: --- → 1.0
What about winstripe?? processing c:/t1/hg/comm-20/calendar/base/jar.mn Traceback (most recent call last): File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 507, in <module> main() File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 504, in main localedirs=options.l10n_src) File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 295, in makeJars jardir=jardir) File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 240, in makeJar localedirs) File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 361, in processJarSection outHelper, jf) File "c:/t1/hg/comm-20/mozilla/config/JarMaker.py", line 393, in _processEntryLine raise RuntimeError('File "%s" not found in %s' % (src, ', '.join(src_base))) RuntimeError: File "themes/winstripe/images/tasks-actions.png" not found in c:\t1\hg\comm-20\calendar\base, .
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
How about putting tasks-actions.png in themes/common/images/ ?
Attached patch Combined Patch (obsolete) (deleted) — — Splinter Review
This patch combines the aero icons and normal icons. I have yet to test this under windows, so not checking in yet. Not requesting review since its basically just a slight modification to the previous patch (and I want this in).
Assignee: nisses.mail → philipp
Status: REOPENED → ASSIGNED
Attached patch Combined Patch - v2 (obsolete) (deleted) — — Splinter Review
This one actually works on windows 7. Maybe someone can test this on windows xp. Otherwise I'll likely push this soon, or look for a machine to test by myself.
Attachment #519523 - Attachment is obsolete: true
Attachment #536145 - Attachment is obsolete: true
Comment on attachment 536242 [details] [diff] [review] Combined Patch - v2 Review of attachment 536242 [details] [diff] [review]: ----------------------------------------------------------------- Tested also on windows xp, works fine. The only issue I noticed on windows is that the disabled state is not always correct and there are lines above and below the toolbar, but thats a different issue. r=philipp
Attachment #536242 - Flags: review+
Attached patch Combined Patch - v3 (deleted) — — Splinter Review
This patch is much better, it uses the "style" chrome registration to register the css files. This means not every rule needs to be !important and we don't need the dummy namespace. I have tested this on windows 7, linux and macosx.
Attachment #536242 - Attachment is obsolete: true
Attachment #537356 - Flags: review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/48cf0f78c33b> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago → 13 years ago
Resolution: --- → FIXED
Target Milestone: 1.0 → Trunk
Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/fe022889d402>
Target Milestone: Trunk → 1.0b4
Attached image error on the priority button icon (deleted) —
There is an error either in the image map or the used css rule. The priority button icon (exclamation mark) shows pixel of the previous icon (checkmark) on the left side, see screenshot. Mozilla/5.0 (Windows NT 6.1; rv:5.0) Gecko/20110605 Thunderbird/5.0b2pre
Will be fixed by bug 662142.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: