Open
Bug 639928
Opened 14 years ago
Updated 2 years ago
XUL persistence should ignore fragments in the page URL
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
NEW
People
(Reporter: mossop, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review-
|
Details | Diff | Splinter Review |
Currently persistence considers urls like chrome://global/content#foo and chrome://hlobal/content#bar as different and so persists different data. It should consider them as the same.
|
Reporter | |
Comment 1•14 years ago
|
||
Fairly straightforward stuff. We just want to consider only the part of the URL before the first # for persistence purposes so everything after gets stripped off whenever persisting values or retrieving persisted values. The test case cycles through cases for chrome: and about: to verify that persistence works.
|
||
Comment 2•14 years ago
|
||
Comment on attachment 518587 [details] [diff] [review]
patch rev 1
Why not use existing url functionality for this instead of reinventing the parsing wheel?
And note that if mDocumentURI is a jar: URI this code is just wrong. Consider:
jar:file:///home/me/foo.jar#bar!/baz.html#woops
Attachment #518587 -
Flags: review?(bzbarsky) → review-
|
|
Reporter | |
Comment 3•13 years ago
|
||
I don't have the time for this anymore
Assignee: dtownsend → nobody
|
||
Comment 5•6 years ago
|
||
No assignee, updating the status.
|
|
||
Comment 6•6 years ago
|
||
No assignee, updating the status.
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•