Closed
Bug 640045
Opened 14 years ago
Closed 14 years ago
Convert Search.pm to use the new AND/OR system internally
Categories
(Bugzilla :: Query/Bug List, enhancement)
Bugzilla
Query/Bug List
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
The very first simple step in implementing the new AND/OR system is to allow the new f1=field&o1=operator&v1=value syntax for just one set.
|
Assignee | |
Comment 1•14 years ago
|
||
Actually, instead, the first step will have to be making Search.pm use the AND/OR system for its internal data structure that represents charts.
Summary: Make the new AND/OR search system able to take one set of arguments → Convert Search.pm to use the new AND/OR system internally
|
|
Assignee | |
Comment 2•14 years ago
|
||
Assignee: query-and-buglist → mkanat
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•14 years ago
|
||
I believe this is a working patch, I have to test it a bit more extensively and look over the code before I check it in, though.
Attachment #517956 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•14 years ago
|
||
This creates two new objects, Search::Clause and Search::Condition, and uses them to generate the final SQL. This is much simpler to understand than my previous patch, and also this patch works where the previous patch did not. :-)
I have tested this manually, and it also passes xt/search.t.
Attachment #520394 -
Attachment is obsolete: true
Attachment #523791 -
Flags: review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
This doesn't change Bugzilla's external behavior (it's just a refactoring) so I checked it in on the main branch instead of my search branch.
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Search.pm
added Bugzilla/Search/Clause.pm
added Bugzilla/Search/Condition.pm
Committed revision 7765.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Flags: approval+
You need to log in
before you can comment on or make changes to this bug.
Description
•