As shown in the attached screenshot, the Firefox 4.0rc1 tab titles seems slightly out of place in the Windows XP theme. It seems to me that this would look better with the text slightly higher (1, possibly 2 pixels).

I'm having the same problem on Windows 7 64-bit. They seem mis-aligned by just a tad.

Oh, I don't know, I think it looks just fine on Windows 7 (with Aero).

Stephen, should we make the tabs shorter for XP too or simply raise the text 1px?

(In reply to comment #4) > Stephen, should we make the tabs shorter for XP too or simply raise the text > 1px? They should be the same height, the text just needs to move up.

Uploading patch shortly.

Does what Stephen intended. :)

Let's get this into Firefox 5 please!

1) This will cause the text to be misaligned with the icon. 2) Whether or not it is "misaligned" very much depends on the typeface. E.g., I use Segoe UI size 8 as my UI font on XP, and it looks just fine. If I tweak it up 1px, it doesn't look any better with respect to tab alignment (but clearly worse with respect to icon alignment). And on NT6+, where Segoe UI 9 is in use, it looks even worse. The important thing is that the icon is properly aligned WRT the tab, and it is in the status quo. And the layout algorithms ensure that the text in turn is aligned with the icon. A blanket override of that alignment to fix a minor "problem" with one typeface just seems wrong (esp. if that is mostly a perceptive problem resulting from the specific shape and sizing of that typeface).

Comment on attachment 524803 [details] [diff] [review] patch (In reply to comment #9) You have valid points. Perhaps, this bug is actually invalid. Stephen, what do you think? Should we move both the favicon and the text? Then, the favicon would no longer have equal horizontal and vertical padding from the tab border. Are we actually using the wrong typeface for our UI on XP or 7?

(In reply to comment #10) > Are we actually using the wrong typeface for our UI on XP or 7? The typeface is correct, since we are (and always have been) using the system UI typeface and font size set in Windows' display preferences. On XP, the default is Tahoma 8, but it can be changed fairly easily, so everyone uses it. If the problem was systemic--where every typeface at every size looks like it's off by 1px--then a fix that bumps everything by 1px would make sense. But the problem isn't systemic, and at the end of the day, it's also a fairly minor issue: something that is probably the result of how things are rounded when centering and/or how a particular typeface appears because of its shape or use of space. BTW, you can use the DOM Inspector to make changes to the CSS on a live install to try out various settings.

Comment on attachment 524803 [details] [diff] [review] patch Moving the label will just make it wrongly aligned in the opposite direction. We'd want to move it by half a pixel (can't do) or subtract a pixel from the tab's top padding (can do). The reason this was seen as XP-specific is probably the different line height we get with DirectWrite, so if bug 643781 got fixed, we would see this across the board. Also, tab-text is the wrong class for this (tab-label would be right).

(In reply to comment #9) > The important thing is that the icon is properly aligned WRT the tab, and it is > in the status quo. It doesn't look quite vertically centered in attachment 518308 [details].

(In reply to comment #11) > BTW, you can use the DOM Inspector to make changes to the CSS on a live install > to try out various settings. Yes, I have been using this. (In reply to comment #12) > Comment on attachment 524803 [details] [diff] [review] > patch > > Moving the label will just make it wrongly aligned in the opposite direction. > We'd want to move it by half a pixel (can't do) or subtract a pixel from the > tab's top padding (can do). > > The reason this was seen as XP-specific is probably the different line height > we get with DirectWrite, so if bug 643781 got fixed, we would see this across > the board. Ah, that makes more sense. Will do. > Also, tab-text is the wrong class for this (tab-label would be right). The difference is non-obvious from just looking at tabbrowser.xml, but after looking at tabbox.xml, I get it now.

Comment on attachment 524879 [details] [diff] [review] patch v2 This causes misalignment when using DirectWrite, so I think we need to exclude Vista/7 for now. Please also add a reference to bug 643781.

Is this what you mean?

Comment on attachment 525103 [details] [diff] [review] patch v3 (backed out) exactly

People on MozillaZine say that this broke tabs touching the edge of the screen when maximized on XP. http://forums.mozillazine.org/viewtopic.php?p=10678595 Alice, can tabs still be selected while the mouse is at the top of the screen?

Gah, Firefox is overly aggressively caching my form fields again!

(In reply to comment #20) > People on MozillaZine say that this broke tabs touching the edge of the screen > when maximized on XP. http://forums.mozillazine.org/viewtopic.php?p=10678595 > > Alice, can tabs still be selected while the mouse is at the top of the screen? See http://forums.mozillazine.org/viewtopic.php?p=10678793#p10678793

(In reply to comment #22) I saw that. There is a difference between the visual appearance of "touching" and whether clicking the top of the screen selects a tab. I am asking to confirm whether clicking the top of the screen still selects a tab.

(In reply to comment #23) > (In reply to comment #22) > > I saw that. There is a difference between the visual appearance of "touching" > and whether clicking the top of the screen selects a tab. I am asking to > confirm whether clicking the top of the screen still selects a tab. clicking at the top of the screen(mouse pointer touch edge) 1. I cannot select tab (normal and pinned tab) 2. I cannot Open NewTab(not overflowed / overflowed state) 3. I cannot scroll tabScrip(left/right side) 4. I cannot open List All Tabs 5. I can still open Firefox button 6. I can still click Minimize/Restore/Close buttons 7. Double clicking at the top of tab etc make browser normal mode

(In reply to comment #24) Okay. I'll get this backed out then.

(In reply to comment #24) And thank you.

Backed out due to XP regression as noted by MozillaZine users and described in comment 24. http://hg.mozilla.org/mozilla-central/rev/a803f8a460be

While I may take another look at this bug before Firefox 6, feel free to take it. Patches are welcome. :)