The pallette in composer's color picker should be focusable. Clicking on the pallette should shift focus to it, as should hitting shift-tab from the "Last- picked color" button. There should be some indication that it is focused (white border around the selected color?). The arrow keys should let the user select different colors.

Marking this bug as blocking bug 64161.

->xptoolkit

->saari

The colorpicker isn't a widget, right (if I'm wrong, point me to the source)? Just a grid of colors, so the composer team should deal with this.

It's an xbl widget (http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/colorpick erBindings.xml)

Giving to cmanske@netscape.com for now. Charley, who owns the color picker widget?

I own the XUL that gives everything *around* the grid of colors in the Colorpicker used for mail and composer. That grid is the <colorpicker> XUL widget and is owned by Pavlov.

This is definitely an accessibility issue. CCing Aaron.

After looking down the path of bug 64161, I see that the focus problem was solved for Browser's colorpicker by hewitt. Unfortunately, this looks tricky, since hewitt is using type="button" on the <colorpicker>, which makes it the *button* that launches the color-grid, while we are using the color grid embeded in our own XUL dialog. Joe: Help!

Bug 56150 has the relevant changes that hewitt made.

The XUL <colorpicker> widget has been changed so it doesn't show the array of colors at all (a button must be pressed to access them).

moving to 0.9.2

Perhaps changing the colorpickertiles from springs to buttons would help?

These are the enhancements made to the colorpicker XBL: 1. Keyhandlers are moved from the button to the colorpicker, so it can work in Composer (and other users who don't want to use 'colorpicker-button'.) The navigation keys (all 4 arrow keys) work when the colorpicker takes focus, and stops when it looses focus. 2. "Space" key support added to select the color (same as Enter key in button version) This allows setting the color in Composer's colorpicker, so you can see the value in the color input field without closing the dialog, as the Enter key does. 3. The color set by the colorbutton (or anyone else who sets the "colorpicker.color" attribute) is initialized so keyboard navigation starts with that color. 4. Recognition of 16 standard HTML color names ("Navy", "Maroon" etc.) when setting the colorpicker.color attribute. 5. CSS styles are tweaked to make the 'hover' cell more noticeable when mouse is hovered over colors or when arrow keys move from color to color. A lighter border color is used when the color swatch is bright.

r=kin

sr=hewitt

a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)

checked in.

verified win2k 2001062803 linux 2001062706 macos 2001062809