Closed Bug 64199 Opened 24 years ago Closed 23 years ago

Need commment in messenger.properties that Inbox, Drafts, Sent, etc. should not be translated

Categories

(MailNews Core :: Localization, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED WORKSFORME
mozilla1.2alpha

People

(Reporter: mkaply, Assigned: rchen)

References

Details

Attachments

(2 files)

We have discovered the hard way that the following things in messenger.properties should not be translated: inboxFolderName=Inbox trashFolderName=Trash sentFolderName=Sent draftsFolderName=Drafts unsentFolderName=Unsent Messages We are unsure about Templates at this point. Anyway, messenger.properties definitely needs a DO NOT TRANSLATE above these strings. Things that happen if you translate these: Can't receive mail Can't delete mail Can't empty trash Can't delete folders etc. etc.
Yes, these are known bugs. This bug needs to go to the mailnews team. Sending it to putterman -- hopefully sspitzer or mscott will take this one. Added l12y keyword.
Assignee: rchen → putterman
Keywords: l12y
reassigning to naving to look into.
Assignee: putterman → naving
Keywords: nsbeta1
BTW, I understand the bigger picture that the bug needs to be fixed, and there are probably bugs related to the specific problem. My only request is that we put a comment in the file now to save people some headaches when they go to translate these :) Thanks
Ray, Allan, (Ying-ling), can you take up on Mike suggests and put in a comment in the messenger.properties file about this?
<offtopic> Can we switch to magic xul tags instead? These strings should be localizable. The flaws as such are in our javascript or whatever for assuming the name of these folders. Is there already a bug for this? </offtopic>
Changes to messenger.properties need to be reviewed before checking into mozilla tree.
localFolders=Local Folders templatesFolderName=Templates These are localizable. Please uncomment the localization notes.
Attached file Fixed per rchen's suggestion (deleted) —
The core bug which fixes this problem has been filed elsewhere. Bug 57440 is the bug and it is slated to be fixed for Mozilla 0.8. Allan, I would make the comment 'optional' when Bug 57440 is fixed. (You might even mention that bug number in the comment.)
I was just about to mention that we hope to fix the other bug. amasri or rchen, will you be able to check this current fix in?
I will check this new fix in as soon as I get code review approval. I presume the person to do this is naving or putterman.
Okay, r = naving
QA contact to ji.
QA Contact: momoi → ji
Bug #57440 is related to this.
reassigning to amasri
Assignee: naving → amasri
Checked in changes
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified with win32 and linux 2001-01-29-06-mtrunk build.
Status: RESOLVED → VERIFIED
the fix for #23625 is going to require templatesFolderName to be non-localized. if that is the case, we'll fix the localization note. note, this is not #57440 which covers the problem where these folder names need to be localizable in the UI.
I'd like to reopen this bug, since in the localization notes, bug 64199 (this bug itself) was mentioned as the cause that makes default mail folders not localizable. And this confused our localizaton engineer at beta1 release. Bug 57440 should be mentioned in the notes.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Ji, currently there are comments already. Do we need to add more comments? # LOCALIZATION NOTES (inboxFolderName): DO NOT TRANSLATE (bugzilla #64199) inboxFolderName=Inbox # LOCALIZATION NOTES (trashFolderName): DO NOT TRANSLATE (bugzilla #64199) trashFolderName=Trash # LOCALIZATION NOTES (sentFolderName): DO NOT TRANSLATE (bugzilla #64199) sentFolderName=Sent # LOCALIZATION NOTES (draftsFolderName): DO NOT TRANSLATE (bugzilla #64199) draftsFolderName=Drafts # LOCALIZATION NOTES (templatesFolderName): DO NOT TRANSLATE (bugzilla #23625). # Fix to bug 23625 requires to create template folder URI for new IMAP account, # which requires the folder name to be picked from here like for other special folders templatesFolderName=Templates # LOCALIZATION NOTES (unsentFolderName): DO NOT TRANSLATE (bugzilla #64199) unsentFolderName=Unsent Messages
No. But we need to replace the bug number #64199 with #57440
reassigning to rchen.
Assignee: amasri → rchen
Status: REOPENED → NEW
Remove the kewords.
Status: NEW → ASSIGNED
Keywords: l12y, nsbeta1
Shouldn't this bug be closed?
Depends on: 57440
Target Milestone: --- → mozilla1.2
Resolved this as WFM.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago23 years ago
Resolution: --- → WORKSFORME
Marked it as verified.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: