Andreas Nilsson (:andreasn) Reporter
	Description • 14 years ago

With all the amazing changes we're making to the main window and the address book, it's only fair that the compose window get some additional love as well.
I think it would be neat to have the background of the address, subject and toolbar area pick up the Firefox toolbar look&feel.

	Andreas Nilsson (:andreasn) Reporter
	Comment 1 • 14 years ago

Putting Richard in cc to see if he have any good feedback on this before I start doing any patches.

	Andreas Nilsson (:andreasn) Reporter
	Comment 2 • 14 years ago

A good question is how we should style the dropdowns. Like the bookmark dropdown in Firefox, or keep it the same as now.

	Andreas Nilsson (:andreasn) Reporter
	Comment 3 • 14 years ago

Watching this window also reminds me how much I want to fix the alignment of things, but that is for another bug :)

	Richard Marti (:Paenglab) Assignee
	Comment 4 • 14 years ago

Actually I have no idea and I don't know what you mean with bookmark dropdown. In plain text mode without the bottom toolbar I see only the possibility of giving radii on the address field.

	Andreas Nilsson (:andreasn) Reporter
	Comment 5 • 14 years ago

Example of bookmarks dropdown button from Firefox.

	Andreas Nilsson (:andreasn) Reporter
	Comment 7 • 14 years ago

Even though it's outside the scope of this bug :)

	Richard Marti (:Paenglab) Assignee
	Comment 8 • 14 years ago

Ah okay, now I know what you mean. The dropdown images should be easy doable. I think the aligning only with CSS is only in a hackish way doable (different label length in other languages). This weekend I'll try to put these headers in a grid. But this will also affect the other platforms, which I think is also appreciated.

	Richard Marti (:Paenglab) Assignee
	Comment 9 • 14 years ago

I tried first with grid but failed because of the addressingWidget listbox. I gave now the first columns a fixed width, which is localized to match different word length. I've added now only the styles for Vista/Win7.

	Richard Marti (:Paenglab) Assignee
	Comment 10 • 14 years ago

Unlike your mockup I have on bottom a visible splitter. Should I do it invisible and maybe make a glow effect on hover like the folderpane splitter when it is collapsed?

	Andreas Nilsson (:andreasn) Reporter
	Comment 11 • 14 years ago

(In reply to comment #10)
> Created attachment 520437 [details]
> MessengerCompose with patch in action
> 
> Unlike your mockup I have on bottom a visible splitter. Should I do it
> invisible and maybe make a glow effect on hover like the folderpane splitter
> when it is collapsed?

If you drag it to the bottom you mean? It looks like it don't get collapsed in exactly the same way as the sidebar, and they cover somewhat different use cases it seems (dragging the header all the way down seems stupid). It might still make sense to do something similar though, just in case.

	Andreas Nilsson (:andreasn) Reporter
	Comment 12 • 14 years ago

(In reply to comment #8)
> Ah okay, now I know what you mean. The dropdown images should be easy doable. I
> think the aligning only with CSS is only in a hackish way doable (different
> label length in other languages). This weekend I'll try to put these headers in
> a grid. But this will also affect the other platforms, which I think is also
> appreciated.

Do I need another patch applied before applying this? I seem to get some rejects on the css file.

	Richard Marti (:Paenglab) Assignee
	Comment 13 • 14 years ago

(In reply to comment #11)
> (In reply to comment #10)
> > Created attachment 520437 [details]
> > MessengerCompose with patch in action
> > 
> > Unlike your mockup I have on bottom a visible splitter. Should I do it
> > invisible and maybe make a glow effect on hover like the folderpane splitter
> > when it is collapsed?
> 
> If you drag it to the bottom you mean? It looks like it don't get collapsed in
> exactly the same way as the sidebar, and they cover somewhat different use
> cases it seems (dragging the header all the way down seems stupid). It might
> still make sense to do something similar though, just in case.

In the image you can see the difference. I marked the splitter. I meant, make the splitter invisible as in your mockup. When the pointer is over the splitter, it will glow to say it exists a splitter (additional to the pointer change with up/down arrow).

	Richard Marti (:Paenglab) Assignee
	Comment 14 • 14 years ago

(In reply to comment #12)
> (In reply to comment #8)
> > Ah okay, now I know what you mean. The dropdown images should be easy doable. I
> > think the aligning only with CSS is only in a hackish way doable (different
> > label length in other languages). This weekend I'll try to put these headers in
> > a grid. But this will also affect the other platforms, which I think is also
> > appreciated.
> 
> Do I need another patch applied before applying this? I seem to get some
> rejects on the css file.

Maybe I played to much. I'll try to make a new with only Aero Glass applied.

	Richard Marti (:Paenglab) Assignee
	Comment 15 • 14 years ago

Patch with new messengercompose-aero.css from hg and Aero Glass patch applied. But still with a weird diff result:

-  margin: 1px;
+  margin: 1px;

	Andreas Nilsson (:andreasn) Reporter
	Comment 16 • 14 years ago

Odd indeed. Might be better to wait to land this until we land the patch in bug 569400

	Andreas Nilsson (:andreasn) Reporter
	Comment 17 • 14 years ago

Still lacking hover and other niceties. Not sure if it applies due to oddness in applying previous patches.

	Richard Marti (:Paenglab) Assignee
	Comment 18 • 14 years ago

(In reply to comment #17)
> Created attachment 521180 [details] [diff] [review]
> some colors
> 
> Still lacking hover and other niceties. Not sure if it applies due to oddness
> in applying previous patches.

No problem for me, I'm applying manual ;)

> <hbox class="top-gradient-thing">

Are you planning something with this class?

The menulists becomes your new button styles only in Aero Glass. Is this intended? Wouldn't it be cleaner if this applies also for every theme in Vista/Win7 like the buttons? Then we have only to add menulist to the button rules and make only special rules for the differences.

	Richard Marti (:Paenglab) Assignee
	Comment 19 • 14 years ago

Patch with changes for all platforms.

Included is also Andreas's additional patch. I applied the Win7 menulist styles together with the toolbarbuttons. The only difference was the text-shadow.

Andreas if you still want the different text-shadow be applied, I can add it.

	Richard Marti (:Paenglab) Assignee
	Comment 23 • 14 years ago

Image shows the inactive menulists in FormatToolbar. Additionally I opened the AttachmentBox.

	Richard Marti (:Paenglab) Assignee
	Comment 24 • 14 years ago

Today I had again access to an XP machine and found a border around the addressingWidget and a to little margin between addressingWidget and msgSubject. The screenshot under XP shows this little margin.

	Richard Marti (:Paenglab) Assignee
	Comment 25 • 14 years ago

Found missing " in patch which made a xml error

	Andreas Nilsson (:andreasn) Reporter
	Comment 26 • 14 years ago

In general, looks really good on Linux and OS X. Great job!
My Windows build is in too much of a "funny" state right now in order for me to test it there, but I'll give it another try tonight and give it a review based on that.

Two small issues:
* As mentioned on IRC, I get an error when applying the patch for the file  mail/themes/qute/mail/compose/messengercompose-aero.css on line 434. Probably a bitrot.
* The compose window on Linux gets too slim and the rightmost widgets in the compose toolbar falls of the screen. I haven't observed this on OS X, not sure why this happens yet.

	Richard Marti (:Paenglab) Assignee
	Comment 28 • 14 years ago

Patch updated after landing of Bug 638964

	Andreas Nilsson (:andreasn) Reporter
	Comment 29 • 14 years ago

This is really odd, I still get issues when trying to apply the patch.
Here are the lines it seems to have issues with http://pastebin.mozilla.org/1202362

It also seems I'm not getting a gradient in the background. Is this an older patch?

	Jim Porter (:squib)
	Comment 30 • 14 years ago

For the Vista/7 theme, you could probably make the attachment area splitter invisible (or however it works for the splitters in the three-pane). That one looks worse than than the splitter at the bottom anyway, since it just stops all of a sudden.

	Richard Marti (:Paenglab) Assignee
	Comment 31 • 14 years ago

(In reply to comment #30)
> For the Vista/7 theme, you could probably make the attachment area splitter
> invisible (or however it works for the splitters in the three-pane). That one
> looks worse than than the splitter at the bottom anyway, since it just stops
> all of a sudden.

I know. I had planned to do this in Bug 643262. First I have to solve the problem mentioned in Comment 29.

	Richard Marti (:Paenglab) Assignee
	Comment 32 • 14 years ago

I've used now diff instead of WinMerge. I hope this solves the problem with applying the patch.

	Andreas Nilsson (:andreasn) Reporter
	Comment 33 • 14 years ago

No, still get the fail, and Blake did too. Fixed the lines in this patch.

	Andreas Nilsson (:andreasn) Reporter
	Comment 34 • 14 years ago

Blake also says it's my fault from changeset 5997 :)

	Andreas Nilsson (:andreasn) Reporter
	Comment 35 • 14 years ago

So it seems the patch I just posted have some incorrect line endings (and that's the reason the patches break). I got a better editor now and will fix those lines up. New patch coming.

	Andreas Nilsson (:andreasn) Reporter
	Comment 36 • 14 years ago

protz fixed me up with a new patch before I got around to do it myself!

	Andreas Nilsson (:andreasn) Reporter
	Comment 37 • 14 years ago

Comment on attachment 526996 [details] [diff] [review]
and a proper

Looks great! ui-r+ on this one!

	Blake Winton (:bwinton) (:☕️)
	Comment 38 • 14 years ago

Comment on attachment 526996 [details] [diff] [review]
and a proper

Review of attachment 526996 [details] [diff] [review]:

So, this patch failed to apply for me, due to some line ending issues, but once I fixed those, it seemed pretty good.

r=me.

	Mark Banner (:standard8)
	Comment 39 • 14 years ago

Checked in: http://hg.mozilla.org/comm-central/rev/d93355b8d755