Closed Bug 642902 Opened 14 years ago Closed 14 years ago

we leak invalid profiles in the jpeg decoder.

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla5

People

(Reporter: jrmuizel, Assigned: joe)

References

Details

(Keywords: memory-leak)

Attachments

(4 files, 4 obsolete files)

don't leak the profile
(deleted), patch
jrmuizel
: review+
Details | Diff | Splinter Review
and again
(deleted), image/jpeg
Details
Add crashtest that will expose the leak v2
(deleted), patch
joe
: review+
Details | Diff | Splinter Review
don't crash if we have a profile
(deleted), patch
jrmuizel
: review+
Details | Diff | Splinter Review
The original patch for color management added this leak. The leak was found using the 'leaks' tool on OS X and recognizing icc profiles in the memory contents. The leak is failing to free here: http://mxr.mozilla.org/mozilla-central/source/modules/libpr0n/decoders/nsJPEGDecoder.cpp#257
Keywords: mlk
Assignee: nobody → joe
Component: GFX: Color Management → ImageLib
OS: Mac OS X → All
QA Contact: color-management → imagelib
Hardware: x86 → All
Attached patch don't leak the profile (deleted) — — Splinter Review
Attachment #520252 - Flags: review?(jmuizelaar)
Blocks: mlk-fx5+
Attachment #520252 - Flags: review?(jmuizelaar) → review+
Depends on: post2.0
Attached image Example image (obsolete) (deleted) —
Attached image try again (obsolete) (deleted) —
Attachment #520312 - Attachment is obsolete: true
Attached image and again (deleted) —
Attachment #520313 - Attachment is obsolete: true
Attached patch Add crashtest that will expose the leak (obsolete) (deleted) — — Splinter Review
Attachment #520319 - Flags: review?(joe)
Address review comments
Attachment #520319 - Attachment is obsolete: true
Attachment #520319 - Flags: review?(joe)
Attachment #520320 - Flags: review+
Attached patch don't crash if we have a profile (obsolete) (deleted) — — Splinter Review
poor. qcms_profile_from_memory() takes a void* as its first argument, so screwing this argument up didn't fail to compile.
Attachment #521291 - Flags: review?(jmuizelaar)
Whiteboard: not-ready
actually qref
Attachment #521291 - Attachment is obsolete: true
Attachment #521291 - Flags: review?(jmuizelaar)
Attachment #521292 - Flags: review?(jmuizelaar)
Attachment #521292 - Flags: review?(jmuizelaar) → review+
http://hg.mozilla.org/mozilla-central/rev/9bc4aefb44db http://hg.mozilla.org/mozilla-central/rev/c1be34bded71 and, because Joe is a pretty smart guy who makes a few mistakes rarely, just because he's human: http://hg.mozilla.org/mozilla-central/rev/5ad746647a66
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2
No longer blocks: mlk-fx5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: