Roberto Sartori Reporter
	Description • 13 years ago

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0

closing firefox with multiple page opened don't request confirmation
and in the options the flag is true

Reproducible: Always

Steps to Reproduce:
1.open 2 or 3 tab
2.close firefox

	Florin Strugariu [:Bebe]
	Comment 1 • 13 years ago

How did you close the firefox?

Because if you use ALT+F4 or the "X" button in the upper corner of the window it asks you to confirm the close

If you use the file exit it is intended not to ask you because it is a 2 step process

	Roberto Sartori Reporter
	Comment 2 • 13 years ago

I close Firefox with the "X" button. I tested also ALT+F4 and I have no message to confirm the close.
now...I've re-downloaded ff4, uninstalled and reinstalled but... no changes! The X button close firefox with no messages

I use the italian version... but I think this isn't the problem !

	[not reading bugmail]
	Comment 4 • 13 years ago

Turn on ask on close warning in options->Tabs and go to about:config in the URL bar and modify preferences:
That should change browser.warnOnQuit = True
You can also change:
browser.showQuitWarning = True to ask if you want to save tabs

	[not reading bugmail]
	Comment 5 • 13 years ago

(In reply to comment #4)
> Turn on ask on close warning in options->Tabs and go to about:config in the URL
> bar and modify preferences:
> That should change browser.warnOnQuit = True
> You can also change:
> browser.showQuitWarning = True to ask if you want to save tabs

That should be the options tabs panel changes:
browser.tabs.warnOnClose;true

	Roberto Sartori Reporter
	Comment 6 • 13 years ago

browser.warnOnQuit and browser.tabs.warnOnClose was already true
browser.showQuitWarning was false and I changed to true but this not solve the problem.

	[not reading bugmail]
	Comment 7 • 13 years ago

then you must check your options->general->startup to show tabs from last time, use show homepage or use default homepage.  Else try a new clean profile using the -profilemanager command line argument.

	Peter
	Comment 8 • 13 years ago

i would love to have it the same way like in ff3. i already tried a new profile, same thing. this setting show tabs from last session is only a half solution, because sometimes i want to erase all open tabs and just start firefox with the startsite.
it is a great feature, i dont know why it is not anymore in ff4

	[not reading bugmail]
	Comment 9 • 13 years ago

well its all there, no differences since ff3 except the the dialog was pref'd off by default, but there is more functionality.

	Peter
	Comment 10 • 13 years ago

oh there is a diffrence, i dont get the question anymore if i would like to save the open tabs or close all tabs or cancel the action (pressing x-button)

its gone...even with above settings..wich are enabled from the beginning

	[not reading bugmail]
	Comment 11 • 13 years ago

It works for me as well as a lot of others.  I cannot help you unless you try to use a clean profile.

	Peter
	Comment 12 • 13 years ago

i tried the clean profile already...and still nothing

	[not reading bugmail]
	Comment 13 • 13 years ago

check the prefs above, you'll have to set them to true in a new profile.

	Atul Aggarwal
	Comment 14 • 13 years ago

I am also able to reproduce this issue on Mac 10.6.4. I have another machine of windows xp and it works perfectly but on mac machine it does not show any warning and closes all the tabs.
I created new profile and verified that Preferences->Tab->Warn me when closing multiple tabs is checked. I also verified that in about:config, browser.WarnOnQuit and browser.tabs.WarnOnQuit is set to true. 

However when I changed browser.showQuitWarning to true (default was false), I am able to see a popup which says "Do you want firefox to save your tabs..." which is definitely a workaround for me to avoid closing firefox by mistake (I tend to press Cmd+Q instead of Cmd+W (for closing window)) 

My User agent is Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

I am ready for any experimentation or trying things to determine exact root cause of the problem.

	Roberto Sartori Reporter
	Comment 15 • 13 years ago

FIRED !!!!

the problem exists only when in options -> privacy the History settings is set to "Don't save".
Anyone can confirm me the same problem ?

	Atul Aggarwal
	Comment 16 • 13 years ago

Nope. Mine setting is Firefox will "Remember History" and still I am able to reproduce this problem.

	[not reading bugmail]
	Comment 17 • 13 years ago

(In reply to comment #15)
> FIRED !!!!
> 
> the problem exists only when in options -> privacy the History settings is set
> to "Don't save".
> Anyone can confirm me the same problem ?

That takes presidence for sure.  So if you remember history (or makes sure check the correct items under custom).

(In reply to comment #14)
> I am also able to reproduce this issue on Mac 10.6.4. 

I have another machine of
> windows xp and it works perfectly but on mac machine it does not show any
> warning and closes all the tabs.

FF4 turned off the dialog by default, so that is correct behavior, it might already be prefed on if you've upgraded your firefox on xp.

> I created new profile and verified that Preferences->Tab->Warn me when closing
> multiple tabs is checked. I also verified that in about:config,
> browser.WarnOnQuit and browser.tabs.WarnOnQuit is set to true. 

Step1 

> However when I changed browser.showQuitWarning to true (default was false), I
> am able to see a popup which says "Do you want firefox to save your tabs..."

Step2!

> which is definitely a workaround for me to avoid closing firefox by mistake (I
> tend to press Cmd+Q instead of Cmd+W (for closing window)) 

Bingo.. the problem is that the default changed on purpose.

> My User agent is Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0.1)
> Gecko/20100101 Firefox/4.0.1

Yup, your using a new profile with FF4.
 
> I am ready for any experimentation or trying things to determine exact root
> cause of the problem.

No more to try.. 

Bug 592822 turned off the dialog by default.. that is why this bug blocks it.

	[not reading bugmail]
	Comment 18 • 13 years ago

Warm me when closing multiple tabs is different then warn to save tabs. So if you set browser.showQuitWarning to true, that gives you the save tabs dialog back and overrides the multiple tabs closing dialog.

The answer is in the combination of the pref settings and turning back on:
browser.showQuitWarning.

For Roberto's problem, he has clear history which will not save tabs and needs to check it back on.