Closed Bug 645338 Opened 13 years ago Closed 6 years ago

Add checkbox inside Firefox's options dialog for browser.showQuitWarning

Categories

(Firefox :: Settings UI, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jake-bmo, Unassigned)

References

Details

(Whiteboard: [quit-dialog-delayed-restore-fallout])

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 6.0; rv:2.0) Gecko/20100101 Firefox/4.0

Since many people seem to have been complaining about the fact that you need to set browser.showQuitWarning in about:config to get the "Save & Quit" dialog back, we should add a checkbox into the options dialog under the "Tabs" panel (where there are already plenty of checkboxes) - maybe something like "Prompt to save tabs on close" or something. That way, if a user wants that option back, they don't have to change about:config or manually use the restore button available in the history menu after starting Firefox to get their tabs back. (A common scenario for me: I close Firefox at night with plenty of important tabs open and forget to go to History > Restore Previous Session in the morning. Then, I later forget all about these tabs.)

Reproducible: Always
Seconded. There's still a checkbox in Preferences > Tabs for "Warn me when closing multiple tabs," but it doesn't seem to do anything; I'm not sure what setting only browser.warnOnQuit does now, and it appears you need to set both to true for the desired behavior. If so, that's what this checkbox should do.
Blocks: 592822
Component: Session Restore → Preferences
QA Contact: session.restore → preferences
Thirded. My suggestion was calling it 'Ask what to do with my tabs on exit' - see https://bugzilla.mozilla.org/show_bug.cgi?id=636777#c2 That solution also changes the quit dialog wording to reflect the fact that all sessions are now saved, even if you click [Quit] in the current dialog.  (The 'Ask what to do' wording similarly avoids falsely giving the impression there's a 'don't save' option, which there isn't.)

Fully agree that it shouldn't be necessary to go into about:config just to toggle a quit prompt.
I fully agree too!
I think this would satisfy the world.
I think we'd have to rejigger some things... flipping that pref shows the dialog most of the time but not all.
Summary: Add checkbox inside Firefox's options dialog for browser.showQuitWaring → Add checkbox inside Firefox's options dialog for browser.showQuitWarning
Whiteboard: [quit-dialog-delayed-restore-fallout]
(In reply to Travis Raines from comment #1)
> Seconded. There's still a checkbox in Preferences > Tabs for "Warn me when
> closing multiple tabs," but it doesn't seem to do anything; I'm not sure
> what setting only browser.warnOnQuit does now, and it appears you need to
> set both to true for the desired behavior. If so, that's what this checkbox
> should do.

We now show the same dialog for quitting or closing with multiple tabs open, and removed the showQuitWarning pref, in Firefox 63. So this option now does what you suggest (ie it turns on/off this warning, together with warnings for closing individual windows with multiple tabs). The fix landed in bug 1438499.

As people here have pointed out in the comments, the session is saved either way (you can restore it from the hamburger menu when you next start Firefox).

If you want to keep a warning for individual windows but turn *off* the warning on quit (I doubt anyone arguing for this bug falls in this category, but just in case...) you can still toggle browser.warnOnQuit to false in about:config (it's true by default).
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.