Closed
Bug 646570
Opened 14 years ago
Closed 13 years ago
Implement Bug 603790 in TB (remove the drop shadow and reduce border radius for buttons)
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 7.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bwinton
:
review+
andreasn
:
ui-review+
standard8
:
approval-comm-aurora-
|
Details | Diff | Splinter Review |
Bug 603790 removed the shadow and reduced the radii of the toolbarbuttons and textfields.
Attachment 523015 [details] shows the difference.
Should we follow this to stay in synch with FF?
Assignee | ||
Comment 1•14 years ago
|
||
Andreas, I added you to know if we should follow this way.
Comment 2•14 years ago
|
||
Yes, I think we should!
It gives less of a heavy appearance, but still looks slick.
Assignee | ||
Comment 3•14 years ago
|
||
Patch implementing the border-radius-, box-shadow- and search-box changes from Firefox. This patch needs Bug 658872 applied.
I made also a whitespace cleanup to be TB style compliant.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #535846 -
Flags: ui-review?(nisses.mail)
Attachment #535846 -
Flags: review?(bwinton)
Comment 4•14 years ago
|
||
Comment on attachment 535846 [details] [diff] [review]
Patch to follow Firefox
Review of attachment 535846 [details] [diff] [review]:
-----------------------------------------------------------------
The code seems fine as far as I can tell. r=me!
Attachment #535846 -
Flags: review?(bwinton) → review+
Updated•13 years ago
|
Summary: Implement Bug 603790 in TB → Implement Bug 603790 in TB (remove the drop shadow and reduce border radius for buttons)
Comment 6•13 years ago
|
||
Comment on attachment 535846 [details] [diff] [review]
Patch to follow Firefox
Looks great, ui-r+ from me!
Attachment #535846 -
Flags: ui-review?(nisses.mail) → ui-review+
Updated•13 years ago
|
Keywords: checkin-needed
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
Comment 8•13 years ago
|
||
Comment on attachment 535846 [details] [diff] [review]
Patch to follow Firefox
It looks like this is only in 8.0, not 7.0, since I don't see it in a current comm-central checkout. Since bug 667248 depends on this patch, we should probably include this in comm-aurora and comm-beta as well.
Attachment #535846 -
Flags: approval-comm-beta?
Attachment #535846 -
Flags: approval-comm-aurora?
Comment 9•13 years ago
|
||
Comment on attachment 535846 [details] [diff] [review]
Patch to follow Firefox
This also depends on at least one more patch, so I don't think we want to take it this late in the cycle.
Attachment #535846 -
Flags: approval-comm-beta?
Attachment #535846 -
Flags: approval-comm-beta-
Attachment #535846 -
Flags: approval-comm-aurora?
Attachment #535846 -
Flags: approval-comm-aurora-
You need to log in
before you can comment on or make changes to this bug.
Description
•