Closed
Bug 647954
Opened 14 years ago
Closed 14 years ago
When extracting add-ons files should be written in binary mode
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ecfbugzilla, Assigned: ecfbugzilla)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
anodelman
:
review+
|
Details | Diff | Splinter Review |
I tried to reproduce Talos results for Adblock Plus and noticed that Adblock Plus was broken in the test profile created. Apparently, the file adblockplus.jar has been written in text mode which broke it on Windows (the ZIP file format doesn't like LF being randomly replaced by CR LF). The problem here is function zip_extractall in ffsetup.py.
|
Assignee | |
Comment 1•14 years ago
|
||
With this change I get more sane results, UI still being intact...
|
||
Comment 2•14 years ago
|
||
CC'ing Justin, as he seems he seems to be the contact person for authors in the "Slow performing Add-ons" campaign, and this bug would impact the test results.
|
|
||
Updated•14 years ago
|
Blocks: AddonSlowStartup
|
||
Comment 3•14 years ago
|
||
Comment on attachment 524153 [details] [diff] [review]
[checked in]Proposed patch
Easy fix, thanks for the patch.
Attachment #524153 -
Flags: review?(anodelman) → review+
|
|
||
Comment 4•14 years ago
|
||
There's a bunch of talos changes post all-hands, I'll get this shepherded into the next available downtime.
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 524153 [details] [diff] [review]
[checked in]Proposed patch
changeset: 229:f67bfd276db0
Attachment #524153 -
Attachment description: Proposed patch → [checked in]Proposed patch
|
|
||
Comment 6•14 years ago
|
||
Rolled out in bug 649175.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•