Closed Bug 648876 Opened 14 years ago Closed 14 years ago

Remove superfluous $(OS_ARCH) filter-outs from js/src/Makefile.in (bug 647389 follow-up)

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla6

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Patch v1 (based on TM rev 4ace629bb676)
(deleted), patch
jimb
: review+
Details | Diff | Splinter Review
Follow-up to bug 647389, which removed all instances of |WINCE| from js/src/Makefile.in This left a few of: > ifeq (,$(filter-out XXXXX,$(OS_ARCH))) and > ifneq (,$(filter-out XXXXX,$(OS_ARCH))) ...whereby XXXXX was just one platform; and as such is equivalent to: > ifeq ($(OS_ARCH),XXXXX) and > ifneq ($(OS_ARCH),XXXXX)
Assignee: general → bmo
Status: NEW → ASSIGNED
Attachment #524969 - Flags: review?(jorendorff)
Attachment #524969 - Flags: review?(jorendorff) → review?(jimb)
Shifting the review to jimb, who actually knows this language ;)
Sorry, just used your r+ in bug 647389 as inspiration for who to pick! :-) Is there a list somewhere of who is best to ask for reviews? (Other than just looking at hg log)
(In reply to comment #2) > Shifting the review to jimb, who actually knows this language ;) Oh, it's a very pleasant little stringy language! You'd *love* it!
Comment on attachment 524969 [details] [diff] [review] Patch v1 (based on TM rev 4ace629bb676) Thanks for the cleanup!
Attachment #524969 - Flags: review?(jimb) → review+
(In reply to comment #5) > Thanks for the cleanup! No problem! Thanks for the speedy review :-)
Keywords: checkin-needed
(In reply to comment #3) > Sorry, just used your r+ in bug 647389 as inspiration for who to pick! :-) > > Is there a list somewhere of who is best to ask for reviews? (Other than just > looking at hg log) hg log and blame work best, but there is also this list: https://wiki.mozilla.org/JavaScript:Hackers
(In reply to comment #7) > hg log and blame work best, but there is also this list: > https://wiki.mozilla.org/JavaScript:Hackers Great, thanks!
http://hg.mozilla.org/mozilla-central/rev/58323bbaaa67
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
(In reply to comment #9) > http://hg.mozilla.org/mozilla-central/rev/58323bbaaa67 Just an FYI - changes in js/src/ should go into the tracemonkey tree. This should be fine this time though, no need for a backout or anything.
(In reply to comment #10) > (In reply to comment #9) > > http://hg.mozilla.org/mozilla-central/rev/58323bbaaa67 > > Just an FYI - changes in js/src/ should go into the tracemonkey tree. This > should be fine this time though, no need for a backout or anything. Sorry, I usually pay attention to not land js checkin-needed stuff, this one got through my list somehow...
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: