See bug 581307 comment #0 for an example of code simplification, although note that for some reason the example uses Importer instead of Getter.

nail, is this still relevant? I'm going through older "good first bugs" that have been inactive for a while. Should it stay a good first bug? Would you like to sign up to mentor it?

Well, there's already been a lot of related activity; partly due to bug 814255 there are already over 400 uses of defineLazyModuleGetter, so I'm not sure how much work there is left here, but I wouldn't have a problem helping someone who wants to have a go at this.

Thanks. I've set your name as mentor

Hi, I am willing to work on this bug. So please I request you to assign it to me. Thanks in Advance, Regards, A. Anup

Go for it!

where can I get the reference and all those to change the code and summary. If possible please explain what is it about?

Hi, Sorry by mistake I have pressed "assign it to default". So, I request you to reassign it to me. Thanks in Advance, Regards, Anup

(In reply to Anup Allamsetty from comment #6) > where can I get the reference and all those to change the code and summary. > > If possible please explain what is it about? OK, so here's a quick example. If you look at browser/components/places/content/places.js you'll see that it imports MigrationUtils.jsm on line 7. But in fact MigrationUtils.jsm is only actually used in the importFromBrowser function on line 355. So by changing that line to a lazy module getter this avoids having to load MigrationUtils unless someone actually wants to import bookmarks from another browser. Now there are a number of cases where we don't want to do this: 1. Tests probably don't need this 2. XPCOMUtils.jsm can't be lazy itself 3. Some modules, such as Services.jsm, are very heavily used and it doesn't make sense to load them lazily. 4. If the module is loaded and then immediately used. For instance the migration utils module could have been loaded by importFromBrowser because it was the only function that needed it.

(In reply to neil@parkwaycc.co.uk from comment #8) > (In reply to Anup Allamsetty from comment #6) > > where can I get the reference and all those to change the code and summary. > > > > If possible please explain what is it about? > > OK, so here's a quick example. > > If you look at browser/components/places/content/places.js you'll see that > it imports MigrationUtils.jsm on line 7. But in fact MigrationUtils.jsm is > only actually used in the importFromBrowser function on line 355. So by > changing that line to a lazy module getter this avoids having to load > MigrationUtils unless someone actually wants to import bookmarks from > another browser. > > Now there are a number of cases where we don't want to do this: > 1. Tests probably don't need this > 2. XPCOMUtils.jsm can't be lazy itself > 3. Some modules, such as Services.jsm, are very heavily used and it doesn't > make sense to load them lazily. > 4. If the module is loaded and then immediately used. For instance the > migration utils module could have been loaded by importFromBrowser because > it was the only function that needed it. are you there on IRC? If so in which channel?

Comment on attachment 826746 [details] [diff] [review] bug Sorry for taking so long to get back to you on this, but we use spaces for indentation, not tabs.

Comment on attachment 829831 [details] [diff] [review] bug Review of attachment 829831 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/places/content/places.js @@ +4,4 @@ > * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > > Components.utils.import("resource://gre/modules/XPCOMUtils.jsm"); > +XPCOMUtils.defineLazyModuleGetter(this, "MigrationUtils", "resource:///modules/MigrationUtils.jsm"); thanks! But please indent this like lines 8 and 9 (being sure to use spaces)