Closed
Bug 649316
Opened 14 years ago
Closed 13 years ago
allow closing tabs in panorama with del and cmd+backspace
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: eyalgruss, Assigned: raymondlee)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
iangilman
:
review+
faaborg
:
ui-review-
|
Details | Diff | Splinter Review |
new tab and undo close tab keyboard shortcuts work in panorama. close tab should work as well for the focused tab. this is useful when closing multiple tab.
Comment 1•14 years ago
|
||
As discussed in bug 579199, I think ctrl+w is a confusing key combo for this feature. I recommend the delete key instead.
Reporter | ||
Updated•14 years ago
|
Summary: allow closing tabs in panorama with ctrl+w → allow closing tabs in panorama with keyboard shortcut (ctrl+w or del)
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to comment #1)
> As discussed in bug 579199, I think ctrl+w is a confusing key combo for this
> feature. I recommend the delete key instead.
Some mac machines e.g. macbook / macbook pro don't have the delete key so cmd+backspace does the same thing.
Updated•13 years ago
|
Summary: allow closing tabs in panorama with keyboard shortcut (ctrl+w or del) → allow closing tabs in panorama with del and cmd+backspace
Assignee | ||
Comment 5•13 years ago
|
||
Handle two keys in Panorama to remove tab item
* delete key
* backspace key (following bookmark manager which user can use backspace to remove bookmark, instead of cmd+backspace)
Assignee | ||
Updated•13 years ago
|
Attachment #542750 -
Flags: feedback? → feedback?(tim.taubert)
Comment 6•13 years ago
|
||
Comment on attachment 542750 [details] [diff] [review]
v1
Review of attachment 542750 [details] [diff] [review]:
-----------------------------------------------------------------
I like that you want to be consistent with the bookmark manager shortcuts but I'm a bit concerned about the backspace key removing tabs as I'm using that "Go Back" in history. That is default on windows systems I think and may yield some really unexpected behavior. Maybe we should ask the UX team to chime in. Anyway, the patch looks good!
::: browser/base/content/test/tabview/browser_tabview_bug649316.js
@@ +8,5 @@
> + gBrowser.addTab();
> + gBrowser.addTab();
> +
> + registerCleanupFunction(function() {
> + hideTabView(function() {});
Nit: please add some code that removes the new tabs if for some reason the other part fails to do so.
Attachment #542750 -
Flags: feedback?(tim.taubert) → feedback+
Assignee | ||
Comment 7•13 years ago
|
||
Add code to remove tabs in registerCleanupFunction
Attachment #542750 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Attachment #542756 -
Flags: ui-review?(faaborg)
Attachment #542756 -
Flags: review?(ian)
Comment 8•13 years ago
|
||
Comment on attachment 542756 [details] [diff] [review]
v2
Review of attachment 542756 [details] [diff] [review]:
-----------------------------------------------------------------
Beautiful.
We do need UX to weigh in on the backspace. I personally like the idea of following the backspace usage in the bookmark manager, but then I don't really care for backspace as "back" key. I can imagine, however, that for people who use the backspace key as their primary "back" key it would be quite jarring to enter Panorama and decide you wanted to "go back" from it, hit the backspace, and instead lose the tab you had been looking at. For that reason, command+backspace (control+backspace on Windows/Linux?) seems like the safest route (in addition to the delete key, of course).
Faaborg, your thoughts?
Attachment #542756 -
Flags: review?(ian) → review+
Comment 9•13 years ago
|
||
As a quick idea, we could allow only "backspace" to remove a tab when ("browser.backspace_action" not in [0, 1]) - http://kb.mozillazine.org/Browser.backspace_action
Comment 10•13 years ago
|
||
bugspam
(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)
No longer blocks: 660175
Comment 11•13 years ago
|
||
Comment on attachment 542756 [details] [diff] [review]
v2
I want to avoid overloading keys because of the possible mode errors. Let's say we use the same keyboard shortcuts both in normal view and in tab view. Then for instance, you expect backspace or delete to clear text when you are in a text field, but since it wasn't focused anymore you end up closing the tab.
The main problem people had with command-w in panorama was that they expected it to close the view itself, but hopefully we've started to address that with the view not looking like it is itself inside of a tab.
Attachment #542756 -
Flags: ui-review?(faaborg) → ui-review-
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → NEW
Assignee | ||
Comment 12•13 years ago
|
||
Based on comment 11, closing this bug.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•