Closed Bug 649367 Opened 14 years ago Closed 14 years ago

"nightly is up to date" does not have enough contrast against the new about window dark backgrounds

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 6

People

(Reporter: khuey, Assigned: Margaret)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch to make text white
(deleted), patch
Gavin
: review+
Details | Diff | Splinter Review
No description provided.
Maybe needs an outline/background like the alt-toggled menu bar on Win7 with Aero?
Version: unspecified → Trunk
A text-shadow could also work, fwiw this is not a text that needs high readability. Btw, I think a better bug to block against is probably bug 648362 that added the new dark backgrounds, the icons by themselves don't cause issues.
Blocks: 648362
No longer blocks: 648368
Summary: "nightly is up to date" does not have enough contrast with the new branding → "nightly is up to date" does not have enough contrast against the new about window dark backgrounds
Keywords: regression
Attached patch patch to make text white (deleted) — — Splinter Review
This patch just makes the text white. I don't think we need to be doing anything complicated here, just ensuring it's readable is a sufficient solution, especially since this only affects nightly/aurora builds.
Assignee: nobody → margaret.leibovic
Status: NEW → ASSIGNED
Attachment #525543 - Flags: review?(gavin.sharp)
Comment on attachment 525543 [details] [diff] [review] patch to make text white Should someone ui-review this? I'm OK with it visually, which is reason for worry.
Attachment #525543 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
Pushed in cedar: http://hg.mozilla.org/projects/cedar/rev/8794c0df7997
Keywords: checkin-needed
OS: Windows 7 → All
Hardware: x86 → All
Whiteboard: [fixed in cedar]
Pushed in m-c: http://hg.mozilla.org/mozilla-central/rev/8794c0df7997
Whiteboard: [fixed in cedar]
Target Milestone: --- → Firefox 6
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Verified on Win7: Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110421 Firefox/6.0a1 Win XP: Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110421 Firefox/6.0a1 Linux: Mozilla/5.0 (X11; Linux i686; rv:6.0a1) Gecko/20110421 Firefox/6.0a1 Mac 10.6: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110421 Firefox/6.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: