Closed
Bug 649722
Opened 14 years ago
Closed 14 years ago
allow MOZ_APP_NAME to be set by configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla6
People
(Reporter: jhford, Assigned: jhford)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
It would be nice to be able to set MOZ_APP_NAME in the mozconfig to avoid filesystem collisions. My specific use case is packaging Firefox in an RPM.
I have been running a copy of firefox for a long time on my linux machines with this patch and --with-app-name=minefield for a couple weeks with no adverse effects.
Attachment #525742 -
Flags: review?(ted.mielczarek)
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → jhford
Status: NEW → ASSIGNED
|
||
Comment 1•14 years ago
|
||
Comment on attachment 525742 [details] [diff] [review]
set MOZ_APP_NAME
Not really sold on the benefits, but I'm not morally opposed to it either.
Attachment #525742 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 525742 [details] [diff] [review]
set MOZ_APP_NAME
Oh, I forgot one thing.
>diff --git a/configure.in b/configure.in
>--- a/configure.in
>+++ b/configure.in
>+if test ! -z "$WITH_APP_NAME" ; then
I believe we more often write this as "if test -n "$WITH_APP_NAME";".
|
|
Assignee | |
Comment 3•14 years ago
|
||
Nits addressed, uploaded in mercurial changeset format.
|
|
Assignee | |
Comment 4•14 years ago
|
||
11 redirection is hard, lets go shopping.
Attachment #526327 -
Attachment is obsolete: true
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Version: unspecified → Trunk
|
||
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
|
||
Updated•6 years ago
|
Target Milestone: Firefox 6 → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•