Closed Bug 650206 Opened 14 years ago Closed 9 years ago

HTML formatter breaks html attribute values when wrapping (need htmlWrapColumn pref for mailnews to add line break on HTML mail)

Categories

(MailNews Core :: Composition, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1225864

People

(Reporter: douglas, Unassigned)

References

(Blocks 1 open bug, )

Details

(Keywords: intl)

User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.16) Gecko/20110323 Ubuntu/10.04 (lucid) Firefox/3.6.16 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 See the mozillazine forum link. HTML inserted into the document is wrapped at 72 characters but then causes anchor 'title' attribute to be spread over two lines. One of three things would fix my problem: 1) editor.HtmlWrapColumn is not ignored, then I could set this higher 2) an option to turn off html indentation would mean that I wouldn't reach the 72 character limit so quickly 3) the html formatter knew not to break html attribute values Reproducible: Always Steps to Reproduce: 1. Open compose window 2. Insert -> HTML 3. Create HTML with nested div's, tables etc 4. Create an anchor with a long 'title' attribute 5. Click Insert 6. Select all in the compose window 7. Insert -> HTML 8. Look at the HTML -- Now go to config editor and change editor.htmlWrapColumn to a big number. Repeat steps - same result Actual Results: Thunderbird applied automatic indentation and inserted line breaks at char 72 Expected Results: Should have honoured HTMLWrapColumn (if that's what it is for..?) Or, see other potential solutions above...
htmlwrapcolumn is gone away. No option to control line break on HTML editor.
The way Thunderbird reformats a composed message's HTML source introduces errors, especially when deeply nested tags cause the automatically inserted indentation to dominate. The indentation also wastes space, which can in some cases nearly double the source length of the email. It would be nice if the user had more control over the formatting of the HTML source. Right now HTML source code is auto-formatted (with no option to configure this), and wrapped at 72 characters (HTMLWrapColumn should supposedly set this, but it doesn't work).
This bug is a cause of bug 653342, and makes "workaround of bug 653342 on CJK mail by large htmlWrapColumn value" impossible. Because of "HTML in mail", "very long line in mail data" can very easily be avoided by "sending in base64 or quoted-printable". Why can "auto-insertion of line breake at 72 unicode characters, even though there is no ascii space at there, for text/html part of mail" and "indention by some spaces after the inserted line break for merely readability of HTML source in text/html part of mail" be mandatory?
Severity: normal → major
Component: Message Compose Window → Editor
Keywords: intl
OS: Linux → All
Product: Thunderbird → Core
QA Contact: message-compose → editor
Hardware: x86 → All
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk
Setting as Core/Editor, and setting intl because this bug is cause of bug 653342. If wrong, correct them, please.
Summary: htmlWrapColumn ignored, html source line breaks problem → htmlWrapColumn ignored, html source line breaks problem (Tb generates bad HTML, by inserting line break followed by some spaces for merely for readability of HTML source, even though at middle of attribute value of HTML tag)
Summary: htmlWrapColumn ignored, html source line breaks problem (Tb generates bad HTML, by inserting line break followed by some spaces for merely for readability of HTML source, even though at middle of attribute value of HTML tag) → htmlWrapColumn ignored, html source line breaks problem (Tb generates bad HTML, by inserting line break followed by some spaces merely for readability of HTML source, even though at middle of attribute value of HTML tag)
This isn't core issue. Although Text formatter and line breaker are into content/*, but mailnews will be have to handle line break by myself when it wants. Also, htmlWrapColumn was broken on Gecko 1.9.0/1. I remove this pref from editor because this is never called. If to implementing this, - content-serializar may have to line breaker for HTML. - mailnews uses it if it is implemented or - mailnews implements this issue by themself.
Component: Editor → Composition
Product: Core → MailNews Core
QA Contact: editor → composition
Summary: htmlWrapColumn ignored, html source line breaks problem (Tb generates bad HTML, by inserting line break followed by some spaces merely for readability of HTML source, even though at middle of attribute value of HTML tag) → need htmlWrapColumn pref for mailnews to add line break on HTML mail.
Summary: need htmlWrapColumn pref for mailnews to add line break on HTML mail. → HTML formatter breaks html attribute values when wrapping (need htmlWrapColumn pref for mailnews to add line break on HTML mail)
WADA was on the right track. The chopping happens in the M-C serialiser, see comment #3.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.